Re: [pdf-devel] [flyspray] Add unit tests for pdf_hash with numeric keys

[gerel]

Well, here is a patch for the given task. It meant fixing a bug not adding
tests ironically. :-P

##
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: address@hidden
# target_branch: file:///home/gerel/PROJECTS/libgnupdf/trunk/
# testament_sha1: 547e4121bbdbd257cea09e78d1f2724e999b3e52
# timestamp: 2008-11-15 15:09:07 -0300
# base_revision_id: address@hidden
#   bn2offyedvnfvbf6
# 
# Begin patch
=== modified file 'src/base/pdf-hash.c'
--- src/base/pdf-hash.c 2008-09-10 19:11:31 +0000
+++ src/base/pdf-hash.c 2008-11-15 18:08:51 +0000
@@ -1,4 +1,4 @@
-/* -*- mode: C -*- Time-stamp: "08/09/10 20:39:43 jemarch"
+/* -*- mode: C -*- Time-stamp: "2008-11-15 15:06:39 gerel"
  *
  *       File:         pdf-hash.c
  *       Date:         Sat Apr  12 12:22:05 2008
@@ -416,15 +416,21 @@
 static int
 key_numeric_p (const char *str)
 {
-  while (str != NULL)
+  if (str != NULL && *str != '\0')
     {
-      if (*str < '0' || *str > '9')
+      while (*str != '\0')
         {
-          return 0;
-        }         
-      str++;
+          if (*str < '0' || *str > '9')
+            {
+              return 0;
+            }  
+          str++;
+        }
+
+      return 1;
     }
-  return 1;
+
+  return 0;
 }
 
 

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWXmb4JMAAdRfgBVQcfv//1oF
BgS//9/+UAPavEqEzVWpWElEyhPCamjCejTU2k0PUPUekNBo0Bp6hzCYBMAJhMJpgAAEyaaBhJJo
IAlPU9TbUYRoR6TygANAyDIcwmATACYTCaYAABMmmgYSSJo0TJkyaNJpqPBT1GZJ5EBpoGhpJLx0
HRY2BtPtpyNTYvLZdU/hKbWJhlBqTqeKRsnteBkA18MTACViC4I3Kmrbqk5zx2Ssz29mnKbEty2o
r4298CBzTm8dRCjwZTjqnpNPl4W6Pzm8Mdf3i1UntaTLJg4vXXbr3uzYdMJM72a9UMPhc9I1Q8mg
r3B+mCxcOfhgQeNn79g8/Bonzas5k5JhSC7mDVPgouvg5eYHHGbdke0oZNBKnFh5EluOUSYTMO1l
xI8/Iw6fg4dMyFFKZ0kazAvN/JskgtYGhTAVyqHgpLl6Kb2jigjRYjCpZjZjXPtn3Dp2LmFTGRX2
sVC3cRyj0oVlpYWkO2991iE7HKqkVOsgPJK7U7KSgxnJSQ1r+CuFsLK554q0rhHInjeReZkMc24v
zTTZ5jA6YvHOIuOT6SosjGayW8lLBV6ZhTxwH1DnUFJTotulMlf7pq0LSTjEh56irmUzktRpqmfS
rrcJKKEwwwmERKCseKsolcTFAt4piAT7Z3sXXmgzHF56xOdbdPORflgOHKSwuCWaTsbMZvl7Tmwv
gx5KwyRNL3Gv0RUW6vab8nlAnmg8ef1MJk+LJj9Uh9P2537jPeq0Ydj43zk0DUMaAgcTxc021mkP
SvZeXEeEgdVCikCBqcpBdOgqKiEn8Fym9a06hKxXislH6+syHaWTTA7AzTHOSxx6BxCnpl5Ehhin
R0K+sonwpxRO3MZcRqcpxjTXrnO8p6E9MgbL/Tcb1kyiPAG3JkZLKo0GLBkCYaryRcXdA4ww0FKm
MpyF0zK6bKKbKGqlqtoTAcNot03jzHpv4B47jfqBkMFeKor9DSWFqWf0g1MMVqHm/HMdV9W3B/ME
nxna7EBUBEuKJ1ejHQw6iFFwcB6p4CeltW4G9+zHhtUwdajEjuzyF65F9tRoJ2KR2JhTJyB2zrqw
B2RwA5HXLzLas2HYrdUQOMETB0AoXJ6sq51FxhhnWt7QIhR1QmGxIwbSZDVByySxiggLDd/rYPay
eywDaVljq9XvgEiTDKIKDDN0mGdgYoZAM8lMtZ1MO462N79sMDZvedncWIq2vrzkbtY8yqcKEwm3
i3icSsoXpxwMhT3PVcqxRUVUBnoo9fPXdrKlfc2gUHetRD7o+39wWwf4u5IpwoSDzN8EmA==

###

cheers

-gerel