[Phpgroupware-cvs] email ChangeLog.ryan--1.1, 1.3 ChangeLog.lex--1.1, 1.3 ChangeLog.core--1.1, 1.3 ChangeLog.brubaker--1.1, 1.2 ChangeLog.codehere--1.1, 1.4 ChangeLog.beta1final--1.0, 1.3 addressbook-js.changelog.txt, 1.3 addressbook-js.php, 1.3 addressbook.php, 1.41 view_image.php, 1.18 index.php, 1.92 attach_file.php, 1.30 compose.php, 1.53

[skwashd]

Update of email

Removed Files:
     Branch: MAIN
            ChangeLog.ryan--1.1
            ChangeLog.lex--1.1
            ChangeLog.core--1.1
            ChangeLog.brubaker--1.1
            ChangeLog.codehere--1.1
            ChangeLog.beta1final--1.0
Modified Files:
     Branch: MAIN
            addressbook-js.changelog.txt lines: +0 -75
            addressbook-js.php lines: +2 -2
            addressbook.php lines: +0 -0
            view_image.php lines: +8 -8
            index.php lines: +3 -3
            attach_file.php lines: +35 -35
            compose.php lines: +0 -0

Log Message:
should have done this a while ago - SaD code

====================================================
Index: email/addressbook-js.changelog.txt
diff -u email/addressbook-js.changelog.txt:1.2 
email/addressbook-js.changelog.txt:1.3
--- email/addressbook-js.changelog.txt:1.2      Fri Mar 14 03:59:53 2003
+++ email/addressbook-js.changelog.txt  Sun Mar 13 23:22:43 2005
@@ -1,75 +0,0 @@
-Hi....:)... good that one of you three are checkling this...
-
-Difference from the preceding tarball:
--This text file
--Comments in addressbook.php
--The addressbook remembers whatever is in the destination boxes (to,cc and 
bcc) and this data
- survives a submit. This is needed since, when you click on a name in the 
source (where the names resulting from a query appear)
- , we do a form.submit so we can go and fetch the extra user data from the 
database -if, and only if, a) U selected ONE name and
- b) the More Data checkbox is on
-
-
-TODO:
-- Keep cleaning up and documenting
-- When you click on a name in the destination boxs, say, to select it for 
removal, this thing does a submit and, so, if u have a single
-  entry in this places, you effectively cannot remove them (its now a 
documented feature...:P)
-- What should happen is, you click on one of the names in the destination 
boxes, it does the submit but IT SEARCHES for the extra data
-  AND REMEMBERS your selection in this boxes....it shouldnt be that hard but 
its very very late (4:30) so im leaving
-
-Please dont hate it, help me improve it.... i think this email clients can be 
cool and easy to use, lets give this kind of
-thing a chance to attract new users and developers into the whole project.
-
-Sunday 22 of september
-
-New Stuff:
-- Change the name of this file from addressbook-chnglog.txt to 
addressbook-js.changelog.txt
-- Changes in selectboxes.js to support a couple of functions we needed for the 
rest of the changes
-- You now can select a single user from a destination box and his data will be 
shown in the more data textarea box
-- Formatting changes in the addressbook-js.tpl to make this thing 
smaller...this was supposed to run in 800x600, now i have no idea how
-  to cram all that inside that
-- The addressbook now remembers everything you clicked regardless of where u 
did it with the exeptions mentioned in the next section
-
-TODO:
-- Keep cleaning and documenting
-- It would be nice if the destination boxes content didnt die when u hit a 
category, sometimes u want to send mail to different categories
-- Sleep, but this is no time to do that.... im going to take a crack at a 
"forward as inline" functionality as a user preference
-
-
-
-Monday 23 of september
-- Lots of caching gets performed so that we dont go and fetch the whole thing 
everytime we click on a name.
-- Bug that made the boxes forget what was in them if u clicked on the 
more-data button
-- Created preferences for your screensize which controls both the size of the 
window that gets poped up and the fonts of
-  the html widgets withing them.
-- Your addressbook choice is now a preference
-
-TODO:
-- Keep cleaning and documenting
-- It would be nice if the destination boxes content didnt die when u hit a 
category, sometimes u want to send mail to different categories
-- Search button still not working...pretty stupid
-- U guys go and test it.... id the behaviour is good, i will move to make it a 
class.... please check it out... i think its production qualuty...im putting it 
online about wensday
-
-Wendsday October 9 2002
-- This changelog entry makes up for the last releases of no documenting the 
changes
-- This thing went into a major overhaul, the js addressbook now is implemented 
in two classes
-  class.uijsaddressbook and class.bojsaddressbook.
-- The templates also changed as we moved to an event driven model of two 
frames, one hidden, one shown
-  The shown frame is basicaly what we were using as an index file 
(addressbook-js.php). The second frame
-  is dynamicaly set byu the event system when it needs to go fetch data from 
the server.
-- The particular stuff each of this classes provides will be put into angles 
documentation style
-  once my life is a bit stabler
-- Major changes include the hability to select the fields you want shown for 
user data, extreme use
-  of caching to improve performance... etc
-
-BUGFIXES:
-- This addressbook now remembers everything with each page submit, actually, 
it will remember your
-  last selections and queries for the rest of your phpgw session.
-- This thing now uses the event system for most everything that doesnt involve 
a query to the database (and ill move that as well)
-  this means it cannot forget your selections on any of the relevant boxes 
unless you requery the database, in which case the present
-  selection of the nameselect box is unimportant and the destboxes are 
refeched from cache.... this baby rocks....
-
-TODO:
-- I have tons of documentation to do, i know.... its good that tony doesnt 
live here cause he would probably shoot me
-  since he is so good at it himself... I promise it wont take long.
-
-

====================================================
Index: email/addressbook-js.php
diff -u email/addressbook-js.php:1.2 email/addressbook-js.php:1.3
--- email/addressbook-js.php:1.2        Fri Mar 14 03:59:53 2003
+++ email/addressbook-js.php    Sun Mar 13 23:22:43 2005
@@ -392,7 +392,7 @@
                                
$GLOBALS['phpgw']->template->set_var('toselvalue',$id);
                                
$GLOBALS['phpgw']->template->set_var('toselname',$firstname." ".$lastname);
                                //Check if this item was selected before
-                               //print "<br>Selected $selected_destination ID 
$id <br>";
+                               //print "<br />Selected $selected_destination 
ID $id <br />";
                                if($selected_destination==$id)
                                {
                                //it was, set it selected

====================================================

====================================================
Index: email/view_image.php
diff -u email/view_image.php:1.17 email/view_image.php:1.18
--- email/view_image.php:1.17   Thu Dec 30 23:13:50 2004
+++ email/view_image.php        Sun Mar 13 23:22:43 2005
@@ -27,18 +27,18 @@
        }
        @set_time_limit(0);

-       echo 'Mailbox = '.$mailbox.'<br>'."\n";
-       echo 'Mailbox = '.$GLOBALS['phpgw']->msg->mailsvr_stream.'<br>'."\n";
-       echo 'Msgnum = '.$m.'<br>'."\n";
-       echo 'Part Number = '.$p.'<br>'."\n";
-       echo 'Subtype = '.$s.'<br>'."\n";
+       echo 'Mailbox = '.$mailbox.'<br />'."\n";
+       echo 'Mailbox = '.$GLOBALS['phpgw']->msg->mailsvr_stream.'<br />'."\n";
+       echo 'Msgnum = '.$m.'<br />'."\n";
+       echo 'Part Number = '.$p.'<br />'."\n";
+       echo 'Subtype = '.$s.'<br />'."\n";
        */
        //$data = 
$GLOBALS['phpgw']->dcom->fetchbody($GLOBALS['phpgw']->msg->mailsvr_stream, $m, 
$p);
        $data = $GLOBALS['phpgw']->msg->phpgw_fetchbody($p);
        //$picture = $GLOBALS['phpgw']->dcom->base64($data);
        $picture = $GLOBALS['phpgw']->msg->de_base64($data);

-       //  echo strlen($picture)."<br>\n";
+       //  echo strlen($picture)."<br />\n";
        //  echo $data;

        Header('Content-length: '.strlen($picture));
@@ -47,7 +47,7 @@
        echo $picture;
        flush();

-       // IS THIS FILE EVER USED ANYMORE?
+       // IS THIS FILE EVER USED ANYMORE?
        if (is_object($GLOBALS['phpgw']->msg))
        {
                $terminate = True;

====================================================
Index: email/index.php
diff -u email/index.php:1.91 email/index.php:1.92
--- email/index.php:1.91        Thu Dec 30 23:13:50 2004
+++ email/index.php     Sun Mar 13 23:22:43 2005
@@ -86,10 +86,10 @@
                $my_msg_bootstrap = CreateObject('email.msg_bootstrap');
                $my_msg_bootstrap->ensure_mail_msg_exists('index.php', 3);

-               echo 'calling CreateObject email.uiindex <br>';
+               echo 'calling CreateObject email.uiindex <br />';
                $GLOBALS['phphw_uiindex'] = new uiindex_holder;
                $GLOBALS['phphw_uiindex']->uiindex_obj = 
CreateObject('email.uiindex');
-               echo 'done calling CreateObject email.uiindex <br>';
+               echo 'done calling CreateObject email.uiindex <br />';
                $GLOBALS['phphw_uiindex']->uiindex_obj->index();
                // STRANGEly enough, menuaction=email.uiindex.index as 
non-module STILL requires an
                // outside-the-class entity to call common->phpgw_footer(), 
eventhough the class itself will

====================================================
Index: email/attach_file.php
diff -u email/attach_file.php:1.29 email/attach_file.php:1.30
--- email/attach_file.php:1.29  Thu Dec 30 23:13:50 2004
+++ email/attach_file.php       Sun Mar 13 23:22:43 2005
@@ -32,7 +32,7 @@
        //$fup_debug=2;

        // #### TESTING BO OBJECT, BYPASSES BYPASS THIS FILE
-       echo 'this file "attach_file.php" is depreciated, use the BO class 
instead<br>';
+       echo 'this file "attach_file.php" is depreciated, use the BO class 
instead<br />';
        $GLOBALS['phpgw']->common->phpgw_exit(False);
        return;
        // #### TESTING BO OBJECT, BYPASSES BYPASS THIS FILE
@@ -69,11 +69,11 @@
        // if we were NOT able to create this temp directory, then make an 
ERROR report
        if (!file_exists($GLOBALS['phpgw_info']['server']['temp_dir']))
        {
-               $alert_msg .= 'Error:'.'<br>'
-                       . 'Server is unable to access phpgw tmp 
directory'.'<br>'
-                       . $GLOBALS['phpgw_info']['server']['temp_dir'].'<br>'
-                       . 'Please check your configuration'.'<br>'
-                       . '<br>';
+               $alert_msg .= 'Error:'.'<br />'
+                       . 'Server is unable to access phpgw tmp directory'.'<br 
/>'
+                       . $GLOBALS['phpgw_info']['server']['temp_dir'].'<br />'
+                       . 'Please check your configuration'.'<br />'
+                       . '<br />';
        }

        if (!file_exists($GLOBALS['phpgw_info']['server']['temp_dir'] . SEP . 
$GLOBALS['phpgw_info']['user']['sessionid']))
@@ -87,11 +87,11 @@
        // if we were NOT able to create this temp directory, then make an 
ERROR report
        if (!file_exists($uploaddir))
        {
-               $alert_msg .= 'Error:'.'<br>'
-                       . 'Server is unable to access phpgw email tmp 
directory'.'<br>'
-                       . $uploaddir.'<br>'
-                       . 'Please check your configuration'.'<br>'
-                       . '<br>';
+               $alert_msg .= 'Error:'.'<br />'
+                       . 'Server is unable to access phpgw email tmp 
directory'.'<br />'
+                       . $uploaddir.'<br />'
+                       . 'Please check your configuration'.'<br />'
+                       . '<br />';
        }

        /*
@@ -114,7 +114,7 @@
        if (($GLOBALS['phpgw']->msg->minimum_version("4.1.0"))
        && (!isset($GLOBALS['phpgw']->msg->ref_FILES)))
        {
-               echo 'file attach_file ('.__LINE__.') ERROR: 
$GLOBALS[phpgw]->msg->ref_FILES should be set here, but it IS NOT set<br>';
+               echo 'file attach_file ('.__LINE__.') ERROR: 
$GLOBALS[phpgw]->msg->ref_FILES should be set here, but it IS NOT set<br />';
        }

        // the following code only applies to php < 4.1.0 where that 
superglobal was not available
@@ -144,7 +144,7 @@
                $file_name = 
$GLOBALS['phpgw']->msg->stripslashes_gpc(trim($GLOBALS['phpgw']->msg->ref_FILES['uploadedfile']['name']));
                $file_size = 
$GLOBALS['phpgw']->msg->stripslashes_gpc(trim($GLOBALS['phpgw']->msg->ref_FILES['uploadedfile']['size']));
                $file_type = 
$GLOBALS['phpgw']->msg->stripslashes_gpc(trim($GLOBALS['phpgw']->msg->ref_FILES['uploadedfile']['type']));
-               if ($fup_debug > 1) { echo 'ref_FILE dump: 
'.htmlspecialchars(serialize($GLOBALS['phpgw']->msg->ref_FILES)).'<br>'; }
+               if ($fup_debug > 1) { echo 'ref_FILE dump: 
'.htmlspecialchars(serialize($GLOBALS['phpgw']->msg->ref_FILES)).'<br />'; }
        }
        else
        {
@@ -183,8 +183,8 @@
                }
                return substr($input, $lastpos + 1, strlen($input));
        }
-       // now use that function to get a clean file name
-       if ($fup_debug > 1) { echo 'file_name (pre-wbasename): ' .$file_name 
.'<br>'; }
+       // now use that function to get a clean file name
+       if ($fup_debug > 1) { echo 'file_name (pre-wbasename): ' .$file_name 
.'<br />'; }
        // Netscape 6 passes file_name with a full path, we need to extract 
just the filename
        $file_name = wbasename($file_name);

@@ -228,10 +228,10 @@
                (($file_tmp_name == '') || ($file_tmp_name == 'none')))
        {
                $langed_attach_file = lang("Attach File");
-               $alert_msg = lang('Input Error:').'<br>'
-                       . lang('Please submit a filename to attach').'<br>'
-                       . lang('You must click').' "'.lang('Attach File').'" 
'.lang('for the file to actually upload').'<br>'
-                       . '<br>';
+               $alert_msg = lang('Input Error:').'<br />'
+                       . lang('Please submit a filename to attach').'<br />'
+                       . lang('You must click').' "'.lang('Attach File').'" 
'.lang('for the file to actually upload').'<br />'
+                       . '<br />';
        }

        $dh = opendir($uploaddir);
@@ -294,25 +294,25 @@
        }

        // begin DEBUG INFO
-       $debuginfo .= '--uploadedfile info: <br>'
-               . '$GLOBALS[phpgw_info][server][temp_dir]: 
'.$GLOBALS['phpgw_info']['server']['temp_dir'].'<br>'
-               . '$GLOBALS[phpgw_info][user][sessionid]: 
'.$GLOBALS['phpgw_info']['user']['sessionid'].'<br>'
-               . 'uploaddir: '.$uploaddir.'<br>'
-               . 'file_tmp_name: ' .$file_tmp_name .'<br>'
-               . 'file_name: ' .$file_name .'<br>'
-               . 'file_size: ' .$file_size .'<br>'
-               . 'file_type: ' .$file_type .'<br>'
-               . '<br>'
-               . 'totalfiles: ' .$totalfiles .'<br>'
-               . 'file_info_count: '.count($file_info) .'<br>'
-               . '<br>';
+       $debuginfo .= '--uploadedfile info: <br />'
+               . '$GLOBALS[phpgw_info][server][temp_dir]: 
'.$GLOBALS['phpgw_info']['server']['temp_dir'].'<br />'
+               . '$GLOBALS[phpgw_info][user][sessionid]: 
'.$GLOBALS['phpgw_info']['user']['sessionid'].'<br />'
+               . 'uploaddir: '.$uploaddir.'<br />'
+               . 'file_tmp_name: ' .$file_tmp_name .'<br />'
+               . 'file_name: ' .$file_name .'<br />'
+               . 'file_size: ' .$file_size .'<br />'
+               . 'file_type: ' .$file_type .'<br />'
+               . '<br />'
+               . 'totalfiles: ' .$totalfiles .'<br />'
+               . 'file_info_count: '.count($file_info) .'<br />'
+               . '<br />';
        if (count($file_info) > 0)
        {
-               $debuginfo .= '<br> file_info[0]='.$file_info[0] .'<br> 
file_info[1]='.$file_info[1];
+               $debuginfo .= '<br /> file_info[0]='.$file_info[0] .'<br /> 
file_info[1]='.$file_info[1];
        }
-       $debuginfo .= '<br>';
+       $debuginfo .= '<br />';
        //print_debug('$debuginfo', $debuginfo);
-       if ($fup_debug > 1) { echo '$debuginfo: '.$debuginfo.'<br>'; }
+       if ($fup_debug > 1) { echo '$debuginfo: '.$debuginfo.'<br />'; }
        // end DEBUG INFO

        $charset = lang('charset');

====================================================