[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Phpgroupware-cvs] ged/doc TODO

From: Pascal Vilarem
Subject: [Phpgroupware-cvs] ged/doc TODO
Date: Sat, 17 Jun 2006 18:05:22 +0000

CVSROOT:        /sources/phpgroupware
Module name:    ged
Changes by:     Pascal Vilarem <maat>   06/06/17 18:05:22

Added files:
        doc            : TODO 

Log message:
        Added "doc" directory with TODO


Index: TODO
RCS file: TODO
diff -N TODO
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ TODO        17 Jun 2006 18:05:22 -0000      1.1
@@ -0,0 +1,53 @@
+30/03/2006 From Dave Hall
+Here is some initial comments:
+DONE : $GLOBALS['phpgw'] -> common -> phpgw_header()
+DONE : needs to be
+DONE : $GLOBALS['phpgw']->common->phpgw_header(true);
+DONE : should work in 16 fine like that too
+$object -> method() should be $object->method(), it is easier on the
+eyes and makes for smaller files.  Smaller files compile faster and so
+the script runs faster  :) 
+The view/download methods should use the methods in the phpgwapi.browser
+Check with Benoit but readfile($version['file_full_path']); I think
+should really use the vfs method for returning the contents of a file.
+$this->t = $GLOBALS['phpgw']->template should be a reference like so
+$this->t =& $GLOBALS['phpgw']->template.  Reduces memory consumption in
+php4 and works properly in php5.  Make sure you use a $this->t->set_root
+in the constructor too.  Similar thing for the db class.
+The icons, cache them in an array, but only when you need them.  look at
+phpgwapi.common.image too  :) 
+object->css() is deprecated in head.  use templates/base/css/base.css
+and prefix all classes and ids with ged_ to avoid conflicts in your css.
+DONE : Header('Location: ' .
+DONE : $GLOBALS['phpgw']->link('/index.php','menuaction=ged.ged_ui.browse'));
+DONE : won't work in head, use
+DONE : $GLOBALS['phpgw']->redirect_link('/index.php', array('menuaction' =>
+DONE : 'ged.ged_ui.browse'));
+Also always use arrays for the second arg for phpgwapi->link it is more
+DONE : The last 2 lines are not needed in index.php 
+Sorry if this is a long list.  It is just things I found while looking
+through the code quickly before and after import.  Any questions, you
+know where to find me  :) 
+As I said on IRC, I think it looks pretty good.  I hope to see this app
+included in 18

reply via email to

[Prev in Thread] Current Thread [Next in Thread]