[Phpgroupware-developers] sitemgr - mssql bugs

[Sigurd Nes]

Some mssql related comments:

1)
Trying the link at 
[Web Content Manager Administration] ->[Manage site-wide module
properties] ->[Register new
modules](menuaction=sitemgr.Modules_UI.findmodules)

resulted in :

        Incorrect syntax near 's'
        Invalid SQL: INSERT INTO phpgw_sitemgr_modules
(app_name,module_name,description) VALUES
('sitemgr','administration','This module presents a link back to the
sitemgr\'s administration menu. It is meant for registered users')

Sollution:

        'addslashes' should be replaced with '$this->db->db_addslashes'

        in class.Modules_SO.inc.php one should replace (line 50):

        e.g replace

        $description = addslashes($description);
        
        with

        $description = $this->db->db_addslashes($description);

2)

function getChildrenIDList and function getFullCategoryIDList() in
class.Categories_SO.inc.php stumble into problems when trying to order
by 'cat_data' on line 17,21 and 35 (mssql cant order by text)

solution : leave as ''

3)
I suspect there are some things fishy about the join statements in the
function 'getallblocksforarea' in class.Content_SO.inc.php(63)

I think it should be altered to (assuming 'view' is altered to
'viewable'):

$sql = "SELECT t1.block_id, area, cat_id, page_id, t1.module_id,
app_name, module_name, arguments, arguments_lang, sort_order, title,
viewable, actif"
. " FROM phpgw_sitemgr_content AS t1 LEFT JOIN "
. " phpgw_sitemgr_modules AS t2 on t1.module_id=t2.module_id LEFT JOIN "
. " phpgw_sitemgr_content_lang as t3 ON (t1.block_id=t3.block_id AND
lang='$lang') "
. " WHERE area = '$area' AND ((page_id = 0 and cat_id = 0)";


Regards Sigurd