Re: [Phpgroupware-developers] A Logging Proposal (long)

[Doug Dicks]

On Thu, 2003-10-02 at 15:19, Chris Weiss wrote:
> First, excelent write of the way it currenlty works!  i didn't even know this
> exsisted in such an easy way to use before now.

Thanks, Chris.  I spent a fair bit of time going through it, and figured
that even if my changes aren't useful the description of what's there
now would be.

> >1) Is this something the team is interested in incorporating into the
> >base PHPGroupware?
> 
> well, most of the work seems to be already done, so I'd say yes

I was hoping this is the case.  I've used a fair bit of open source
software over the years and would like to contribute back to the
community in some small way at least.

> >2) Is having the file name and line number useful?
> 
> Sometimes it is.  Some can easily be repeated among extended classes, nice to 
> know
> where the message is /really/ comming from.  However, making them optional 
> would be
> fine.
> Would be easy to do this using func_get_args() and if the first arg is an 
> array use
> the old style, otherwise use the newer simple style.

Yes, I can do that.  I don't have a problem supporting both ways if
there are no strong opinions one way or another.

> >3) Should I use print_r on the parameters before substituting them?
> 
> only if it's running under php 4.3 or newer.  For 4.2 and newer, var_export is
> interesting.  Possibly even just serialize it so the array/object can be 
> copy/pasted
> for test script recreation.  i typicaly print_r things, but that's not easy to
> capture pre-4.3 and most people are still using pre-4.3.

The ob_ functions were added in 4.3?  I didn't know that - but I'm
rather new to PHP so I'm not surprised.  I can try to make it a version
specific thing, a configuration parameter, or just drop it for now.  We
could always add it later. 

> >4) Should I include options to write logging messages to standard output
> >as viewable HTML or/and within comments?
> 
> Check how email does this.  It puts the contents in a popup window, kinda 
> cool.

I'll look at that.

Thanks,

Doug