Re: RE: RE: [Phpgroupware-developers] More problems found during the SAP DB port

[Dave Hall]

Kai Hofmann <address@hidden> wrote:

> > > Schema changes are only to rename the reserved column names a 
> bit -
> > > so for async I renamed "next" to "nextid".
> > 
> > Unfortunately that patch (and some others you have submitted) 
> > have to be
> > redone.  Always use latest cvs.
> 
> can you please let me know which ones exactly?

The tracker should have sent you an auto update on them, I don't keep
the tracker updates.

> 
> > > So the changes are not so big - the most problem is to find out 
> all> > SQL statements using such a field by grep.
> > > 
> > 
> > What time lines are you looking at and what is your test 
> plan/process> for these changes?
> 
> my timeline ist 20.11. because from 21.11. I am on vacation ;-)
> Tests will happen inhouse by our other developers. Also a code review
> will happen by someone other.

20 Nov?  I think we will all be making lists of what must be fixed for 
001 by then :)

> 
> > > Btw. I have created resevered keyword identifier lists for
> >
> > 
> > The lists will be very handy.
> > 
> > This also raises an interesting point.  by using the 
> > sql_generator code
> > from eald, such a change could be made once by simply adding a field
> > alias and updating the schema.
> > 
> > Maybe for head we could look a adding the reserved word list 
> > to the api,
> >  this would be checked by dbtools (which imho) should be moved 
> from eT
> > to dev_tools.  The list could also be checked when setup 
> generates the
> > schema.
> 
> these checks should be only enabled for developers - i.e. in debug 
> mode.My proposal would be to have different debug levels.
> 
> For debugging I added code to the SAPDB class to check if there is 
> a ";" at
> the end of an sql statement and warn about it.
> 
> Greetings
> 
>   Kai
> 
> 
> _______________________________________________
> Phpgroupware-developers mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/phpgroupware-developers
>

dave.hall.vcf
Description: Card for <dave.hall@mbox.com.au>