Re: [Phpgroupware-developers] new template-set

[Dave Hall]

Chris Weiss <address@hidden> wrote:

> ah, now I see what you were trying to do, copy the behaviour of the 
> default template
> set, which would be inconsistant with what your doing with the navbar.
> 
> Here's a working version that keeps text only on the left and 
> handles it in what I
> think is a cleaner way
>
http://todolist.epconline.net/phpgw16/phpgwapi/templates/probusiness/navbar.inc.phps
> 
> though there's a $PHP_SELF thing in there, you shouldn't be using 
> that past php 4.0,
> Dave will fill in the detail.

Ok, this is what I propose we do:

* Add Chris' fixes
* Add (c) info to the headers
* Bring it up to PHP4.1 compliance - ie use the super globals ($_GET not
$GLOBALS['HTTP_GET_VARS'])
* Change the logo to be the phpgw logo

I am happy to do some of this work, then import it.  For the template to
remain in the 16 branch the work would need to be completed for
16-final.  I think this is a good compromise :)

> 
> Also, please use tabs instead of spaces, that way each dev can 
> choose their own
> space display pref in their editor and everyone stays happy.
> 

That is some boring work I won't be doing ;)

Cheers

Dave

> 
> Chris Weiss (address@hidden) wrote:
> >
> >found it...
> >
> >for Show navigation bar as choose Text Only.  In
> >phpgwapi/templates/probusiness/navbar.inc.php around line 65... if 
> navbar_format =
> >text then it fills this $tabs array and doesn't seems to do 
> anything with it right
> >away, and doesn't fp the app_rows to give it a handle so the
> >$tpl->parse('navbarview','app_rows',false); call fails.
> >
> >Philipp Kamps (address@hidden) wrote:
> >>
> >>Hi Chris,
> >>
> >>I just uploaded a new version of the tpl-set to our
> >>web server.
> >>I couldn't reproduce the error you experienced. Hope
> >>the update is doing the trick.
> >>
> >>Sorry for this incomplete help.
> >>
> >>Regards, fips
> >>
> >>Am Di, den 14.10.2003 schrieb Chris Weiss um 18:41:
> >>> Template Error: loadfile: app_rows is not a valid handle.
> >>> Halted.
> >>>
> >>> didn't say what file it was in but it was still in the prefs app.
> >>> this is on .14.510 (.16 cvs updated yesterday)
> >>>
> >>>
> >>> Philipp Kamps (address@hidden) wrote:
> >>> >
> >>> >Hi ya,
> >>> >
> >>> >we actually put some effort in creating a template-set
> >>> >for the phpGroupWare. It is based on a actuall cvs
> >>> >version of the Branch 'phpgw-0_9_16-branch'.
> >>> >
> >>> >Feel free to test it and comment it:
> >>> >http://www.probusiness.de/projekte/phpgroupware/
> >>> >
> >>> >Contact persons for this template-set are:
> >>> >
> >>> >Daniel Briegert: address@hidden
> >>> >Philipp Kamps  : address@hidden
> >>> >
> >>> >Regards, fips
> >>> >
> >>> >
> >>> >
> >>> >_______________________________________________
> >>> >Phpgroupware-developers mailing list
> >
> >>> >address@hidden
> >>> >http://mail.gnu.org/mailman/listinfo/phpgroupware-developers
> >>> >
> >>>
> >>>
> >>>
> >>> _______________________________________________
> >>> Phpgroupware-developers mailing list
> >>> address@hidden
> >>> http://mail.gnu.org/mailman/listinfo/phpgroupware-developers
> >>
> >>
> >>
> >>_______________________________________________
> >>Phpgroupware-developers mailing list
> >>address@hidden
> >>http://mail.gnu.org/mailman/listinfo/phpgroupware-developers
> >>
> >
> >
> >
> >_______________________________________________
> >Phpgroupware-developers mailing list
> >address@hidden
> >http://mail.gnu.org/mailman/listinfo/phpgroupware-developers
> >
> 
> 
> 
> _______________________________________________
> Phpgroupware-developers mailing list
> address@hidden
> http://mail.gnu.org/mailman/listinfo/phpgroupware-developers
>

dave.hall.vcf
Description: Card for <dave.hall@mbox.com.au>