[Phpgroupware-developers] Problems with drop column in wrong place in upgrade scripts

[Jonathan Rivera]

Hi everybody,


I am working to add addessmaster account and create the contact for each
account, but in my review of the tables_update.inc.php script i see that
in the function phpgwapi_upgrade0_9_14_508()

at the finish this has:

$GLOBALS['phpgw_setup']->oProc->DropColumn(....)

for delete the ab_id column from phpgw_contact, phpgw_contact_person and
phpgw_contact_org tables, this "ab_id" column is used for migrate the
addressbook to the new contacts backend, but i think this is wrong place
for do this, because all others applications have to use this ab_id column
for migrate his records, so i think this drop column would be run after
all applicatios has been upgrade his data.

This is a problem, but i think the solution is remove the calls to
$GLOBALS['phpgw_setup']->oProc->DropColumn(....)
 from this function and do this after all applications has been upgraded.

Please comment.