Re: RE: [Phpgroupware-developers] More on SAPDB support - long list

[Dave Hall]

Kai Hofmann <address@hidden> wrote:

> > From: Chriss Weiss
> >
> > that depends on what's wrong with them.  If it's a programming 
> error and
> is broke on
> > any db a patch for .16 will be appreciated, but if it's just for 
> SAP *I*
> think it
> > will have to go to HEAD.  changing field names is tricky and I 
> think it's
> too late
> > in .16 to do that.
> 
> SAPDB support is for me a 0.9.16 target - independently of the 
> official0.9.16 release.
> If you don't want it in the official 0.9.16 release I will create 
> a patch
> set for our customers.
> Also I don't understand whats tricky by renaming columns - thats a 
> job that
> I would
> delegate to a trainee without problems.

Do you have a team of trainee testers?  Who can thoroughly test the
changes on mysql, pgsql and mssql on various versions of php running on
various distros/OSes?

> Btw. when the mentioned apps are already broken it would not harm 
> to fix
> these and maybe other
> things for 0.9.16 - otherwise they should not have been tagged for 
> 0.9.16 in
> cvs (in my opinion).
> 

The 16 branch was created in January or Febuary - many things have
changed since then.  Some apps will be dropped from the RC2 release.

<snip /> 

Responses inline :)

> 
> Database error: Invalid SQL: INSERT INTO phpgw_config 
> VALUES('phpgwapi','freshinstall', 1)
> 
> ##
> ODBC Error: 23000 ([SAP AG][SQLOD32 DLL][SAP DB]Integrity constraint
> violation;-8006 POS(61) Data types must be compatible:CONFIG_VALUE.)
> blob must be in ''

Fixed - although this was tested on mysql and worked :P

> 
> --------
> 
> Database error: Invalid SQL: CREATE TABLE phpgw_p_invoice (id 
> SERIAL NOT
> NULL, p_number VARCHAR(20) NOT NULL, date INTEGER NOT NULL DEFAULT 
> '0',project_id INTEGER NOT NULL DEFAULT '0', customer INTEGER NOT 
> NULL DEFAULT
> '0', sum DECIMAL(20,2) NOT NULL DEFAULT '0', owner INTEGER NOT 
> NULL DEFAULT
> '0', PRIMARY KEY(id), UNIQUE(p_number))
> 
> ####
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-7006 POS(82) Reserved identifier 'date' not allowed.)
> File: 
>
E:\Dokumente\phpgwapi0916\phpgwapi\inc\class.schema_proc_sapdb.inc.phpLine:
508

ceb's app - raise it with her

> 
> -------------------------------------------------------------
> 
> Database error: Invalid SQL: CREATE TABLE phpgw_eldaptir_schema 
> (id INTEGER
> NOT NULL, _oid VARCHAR(64), name VARCHAR(64), extra VARCHAR(255), 
> descrVARCHAR(255), must VARCHAR(255), may VARCHAR(255))
> 
> #####
> 
> ODBC Error: S1000 ([SAP AG][SQLOD32 DLL][SAP DB]General error;-
> 5006 POS(58)
> Missing identifier.)
> "_" ist not allowed
> 
> -----------------
> 

Unmaintained - will look at how broken it is overall


> Database error: Invalid SQL: CREATE TABLE phpgw_headlines_cached (site
> INTEGER NOT NULL, title VARCHAR(255), link VARCHAR(255))
> 
> ####
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-7006 POS(81) Reserved identifier 'link' not allowed.)
> File: 
>
E:\Dokumente\phpgwapi0916\phpgwapi\inc\class.schema_proc_sapdb.inc.phpLine:
495
> 
> ------

Working on this atm

> 
> Database error: Invalid SQL: CREATE TABLE phpgw_discuss (msg_id 
> INTEGER NOT
> NULL, name VARCHAR(255) NOT NULL, comment VARCHAR(255) NOT NULL, count
> INTEGER NOT NULL)
> 
> #####
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-7006 POS(113) Reserved identifier 'count' not allowed.)
> File: 
>
E:\Dokumente\phpgwapi0916\phpgwapi\inc\class.schema_proc_sapdb.inc.phpLine:
508

Ummm what app is this?  I have never heard of it, also i don't know it
is tagged for 16

> 
> ------------------
> 
> Database error: Invalid SQL: CREATE TABLE phpgw_messenger_messages
> (message_id SERIAL NOT NULL, message_owner INTEGER NOT NULL, 
> message_fromINTEGER NOT NULL, message_status CHAR(1) NOT NULL, 
> message_date INTEGER NOT
> NULL, message_subject LONG NOT NULL, message_content LONG NOT 
> NULL, 
> PRIMARY KEY(message_id), UNIQUE(message_id))
>                         ##################
> ODBC Error: S0011 ([SAP AG][SQLOD32 DLL][SAP DB]Index already 
> exists;-7055
> POS(289) Column(s) already indexed.)
> 
> No comment on this - really stupid

Jengo's app


> 
> ------------------
> 
> Database error: Invalid SQL: CREATE TABLE news_msg (con INTEGER 
> NOT NULL,
> msg INTEGER NOT NULL, uid VARCHAR(255), udate INTEGER DEFAULT '0', 
> pathVARCHAR(255), fromadd VARCHAR(255), toadd VARCHAR(255), ccadd 
> VARCHAR(255),bccadd VARCHAR(255), reply_to VARCHAR(255), sender 
> VARCHAR(255), return_path
> VARCHAR(255), subject VARCHAR(255), message_id VARCHAR(255), reference
> VARCHAR(255), in_reply_to VARCHAR(255), follow_up_to VARCHAR(255),
> nntp_posting_host VARCHAR(255), nntp_posting_date VARCHAR(255),
> x_complaints_to VARCHAR(255), x_trace VARCHAR(255), x_abuse_info
> VARCHAR(255), x_mailer VARCHAR(255), organization VARCHAR(255), 
> content_typeVARCHAR(255), content_description VARCHAR(255), 
> content_transfer_encodingVARCHAR(255), mime_version VARCHAR(255), 
> msgsize INTEGER DEFAULT '0',
> msglines INTEGER DEFAULT '0', body LONG NOT NULL, PRIMARY 
> KEY(con,msg)) 
> ###
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-7006 POS(68) Reserved identifier 'uid' not allowed.)
> File: 
>
E:\Dokumente\phpgwapi0916\phpgwapi\inc\class.schema_proc_sapdb.inc.phpLine:
508
> 
> ------------

Unmaintained - I have done some work on it.  

> 
> Database error: Invalid SQL: CREATE TABLE mrbs_entry (id SERIAL 
> NOT NULL,
> start_time INTEGER NOT NULL DEFAULT '0', end_time INTEGER NOT NULL 
> DEFAULT'0', entry_type INTEGER NOT NULL DEFAULT '0', repeat_id 
> INTEGER NOT NULL
> DEFAULT '0', room_id INTEGER NOT NULL DEFAULT '1', timestamp 
> TIMESTAMP NOT
> NULL, create_by VARCHAR(25) NOT NULL, name VARCHAR(80) NOT NULL, type
> CHAR(1) NOT NULL DEFAULT 'E', description LONG, PRIMARY KEY(id))
> 
> #########
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-7006 POS(245) Reserved identifier 'timestamp' not allowed.)
> 
> ------------------

rbs uses mysql only db functions - I doubt this will change for 16

> 
> Database error: Invalid SQL: CREATE TABLE phpgw_wiki_links (page 
> VARCHAR(80)NOT NULL, link VARCHAR(80) NOT NULL, count INTEGER NOT 
> NULL DEFAULT '0',
> PRIMARY KEY(page,link))
> 
> ####                       #####
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-7006 POS(59) Reserved identifiers 'link', 'count' not 
> allowed.)
> ------------------

This app is ported from wikki tikki tavi, with only very minor mods for
it to work on phpgw.  Please raise the issue upstream -
http://sf.net/projects/tavi

> 
> Database error: Invalid SQL: INSERT INTO phpgw_brewer_hops
> (name,avg_alpha,avg_iols) VALUES ('Brewer\'s_Gold',7.00,1.50)
> 
> ??
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-3014 POS(81) Invalid end of SQL statement.)
> 
> I have to check out this - maybe this is a much larger problem 
> with the
> handling of ' in different databases.
> For example in Sybase it must be written as ''
> 

Brewer will be dropped from RC2 - and hopefully from CVS completely -
IMHO is does not belong in phpgw.  To avoid the \' '' issues, all devs
should be using db::db_addslashes($str)


<snip />

> 
> Database error: Invalid SQL: UPDATE phpgw_categories SET cat_main 
> = WHERE
> cat_id =
>                                                                  ###
> ####
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-3014 POS(47) Invalid end of SQL statement.)
> 
> Nice thing - no values present!
> 

Instructions on how to replicate this one?

> 
> 
> Database error: Invalid SQL: INSERT INTO phpgw_sitemgr_sites
>
(site_id,site_name,site_url,site_dir,themesel,site_languages,home_page_id,an
> onymous_user,anonymous_passwd) VALUES (,'Default
> Website','/sitemgr/sitemgr-
> site/','E:\Dokumente\phpgwapi0916/sitemgr/sitemgr-
> site','phpgroupware','en',0,'anonymous','anonymous') 
> ##            
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-5010 POS(148) Missing value specification.)
> 
> When site_id is an autoincrement field, it should not be presend 
> either -
> otherwise a value is required.

Agreed

<snip />

> Database error: Invalid SQL: INSERT INTO phpgw_wiki_pages
> (title,version,time,supercede,username,author,body,comment) VALUES
> ('RecentChanges',1,1068456721,1068456721,'setup','localhost','[[! 
> *]] ','')
> ODBC Error: S0002 ([SAP AG][SQLOD32 DLL][SAP DB]Base table not 
> found;-4004
> POS(13) Unknown table name:PHPGW_WIKI_PAGES.)
> 
> oops missing create or a ";" problem in the create - have to look 
> into it.
> 

Leave you to sort this one :P

> 
> Database error: Invalid SQL: CREATE TABLE phpgw_inv_products (con 
> SERIAL NOT
> NULL, id VARCHAR(20) NOT NULL, serial VARCHAR(64) NOT NULL, name
> VARCHAR(255) NOT NULL, descr LONG, category INTEGER NOT NULL 
> DEFAULT '0',
> status INTEGER NOT NULL DEFAULT '0', weight INTEGER NOT NULL 
> DEFAULT '0',
> cost DECIMAL(10,2) NOT NULL DEFAULT '0', price DECIMAL(10,2) NOT NULL
> DEFAULT '0', retail DECIMAL(10,2) NOT NULL DEFAULT '0', stock 
> INTEGER NOT
> NULL DEFAULT '0', mstock INTEGER NOT NULL DEFAULT '0', url 
> VARCHAR(255) NOT
> NULL, ftp VARCHAR(255) NOT NULL, dist INTEGER NOT NULL DEFAULT 
> '0', pdate
> INTEGER NOT NULL DEFAULT '0', sdate INTEGER NOT NULL DEFAULT '0', bin
> INTEGER NOT NULL DEFAULT '0', product_note LONG, PRIMARY KEY(con))
> 
> ######
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-7006 POS(80) Reserved identifier 'serial' not allowed.)
> 
> ------

ceb's app which will be dropped from RC2 as it has many issues atm.

> 
> Database error: Invalid SQL: CREATE TABLE fm_equipment (equipment_id
> VARCHAR(20) NOT NULL, equipment_type_id INTEGER, descr VARCHAR(255),
> category INTEGER, owner INTEGER, access VARCHAR(7), location_code
> VARCHAR(20), objekt_id VARCHAR(4), property_name VARCHAR(50), bygg_id
> CHAR(2), building_name VARCHAR(50), seksjons_id CHAR(2), etasje 
> VARCHAR(6),leie_id CHAR(3), street VARCHAR(50), vendor_id INTEGER, 
> date INTEGER,
> lifetime INTEGER, status VARCHAR(10), PRIMARY KEY(equipment_id))
> 
> ####
> ODBC Error: 37000 ([SAP AG][SQLOD32 DLL][SAP DB]Syntax error or access
> violation;-7006 POS(378) Reserved identifier 'date' not allowed.)
> 

Property - sigurd


> 
> 
> create table problems:
> 
> Database error: Invalid SQL: INSERT INTO phpgw_inv_statuslist 
> (status_name)VALUES ('available')
> ODBC Error: S0002 ([SAP AG][SQLOD32 DLL][SAP DB]Base table not 
> found;-4004
> POS(13) Unknown table name:PHPGW_INV_STATUSLIST.)

See comments re inv above

<snip />

> 
> also create table problems:
> 
> Database error: Invalid SQL: INSERT INTO fm_request_type 
> (request_type_id,type_descr, category, owner, access) VALUES 
> ('Klage', 'Klage fra leieboer',
> NULL, NULL, NULL)
> ODBC Error: S0002 ([SAP AG][SQLOD32 DLL][SAP DB]Base table not 
> found;-4004
> POS(13) Unknown table name:FM_REQUEST_TYPE.)
> 

<snip type="more property stuff" />

I am not sure if sigurd wants the 14 branch version of property in 16


Woooo hoooo!!!! none of them are my apps!

Cheers

Dave

dave.hall.vcf
Description: Card for <dave.hall@mbox.com.au>