Re: [phpGroupWare-developers] status of trunk in svn

[Sigurd Nes]

Dave Hall wrote:
> On Sat, 2008-04-19 at 11:09 +0200, Sigurd Nes wrote:
>> Dave Hall wrote:
>>> On Sat, 2008-04-19 at 00:26 +0200, Sigurd Nes wrote:
>>>> Dave Hall wrote:
>>>>> On Thu, 2008-04-17 at 18:53 +0200, Olivier Berger wrote:
>>>>>> Le jeudi 17 avril 2008 à 11:03 +0200, christian bac a écrit :
>>>>>>> I can propose diffs from my version and the trunk, but last time I did
>>>>>>> it, skwashd talled that there were new versions in the <<resight tree>>,
>>>>>>> that already had the same fixes.
>>>>>>>
>>>>>>> When will the resight tree changes be merged to trunk.
>>>>> This is a question for Sigurd to answer.
>>>>>
>>>> I'm glad to see that the activity is picking up, there has been very 
>>>> little of
>>>> it on savanna (except for ged) lately - and the sync has mostly moved code 
>>>> one
>>>> way - and the code needs manual tweaking before sync:
>>>>
>>>> 1) The resight project really need a method for quickly switch from
>>>> developer-mode to end-user mode - suspending the notices to be printed due 
>>>> to
>>>> frequently testing and demonstration of the system for non-developers.
>>>>
>>>> This is implemented in the resight tree as a check on the error-log-level 
>>>> - and
>>>> it would be very nice if the community - at least for now - could allow 
>>>> this
>>>> feature to survive.
>>>>
>>>> 2) We are working on a new template - as until yesterday was temporary 
>>>> named as
>>>> 'newdesign' - some renaming  - and it should be ok to sync across.
>>>>
>>>> 3) The structure is not identical in the two repos.
>>> The question was when, not how or what.  I think the community has a
>>> right to know when to expect the bugs we (resight) introduced into the
>>> tree will be fixed.
>>>
>> When: allow 1)
> 
> Someone just needs to write the code which was proposed last time this
> was discussed.  I am sure the community would be happy to accept the
> code when provided.
> 
Why not just allow the extra line of code in functions.inc.php:
                                
if(isset($GLOBALS['phpgw_info']['server']['log_levels']['global_level']) &&
$GLOBALS['phpgw_info']['server']['log_levels']['global_level'] == 'N')
{
 echo "\n<br>" . lang('ERROR Notice: %1 in %2 at line %3', $error_msg,
$error_file, $error_line) . "<br>\n";
}

>>  - fix 2)
> 
> This is hardly a blocker, it has always been excluded from syncs.  btw
> any timeline on this? 
> 
>>  and 3).
> 
> It is resight who chose a different tree structure.  This is something
> that we need to discuss internally, not here.  It also doesn't prevent
> any syncs.
> 

Regards

Sigurd