Re: [phpGroupWare-developers] New logo trial

[Maât]

Sigurd Nes a écrit :
>> From: Maât address@hidden
>>
>> http://home.vilarem.net/phpgroupware/phpgroupware_developer_guide_draft0_en_US.pdf
>>     
> A great start (- and the logo is very nice)
>   
thanks :)

> Some first remark on the developer guide:
>
> *1)
> 3.2.2.4 class.menu.inc.php file:
> I think there is a preferences section - as:
>
> if ( isset($GLOBALS['phpgw_info']['user']['apps']['preferences']) )
> {
>       $menus['preferences'] = array
>       (
>   
I trid to make the menu as simple as i could... perhaps i removed too
many things.

Are preferences and admin sections really needed for a "hello world" app ?

>
> *2)
> the baseline.inc.php in setup: is it needed?
>   
dunno... if someone could tell  that would be welcome.

The whole phpGroupWare infrastructure changed since this doc was written
(db, xslt, acl2, new menu....) so there are chances that many things in
infrastructure chapter or API chapter are not valid any more.

That's why i cross posted on docteam and dev lists : i need developers
help to check for wrong things

> *3)
> 6 Database layer in depth:
> Might have something on transactions here?
>
> example:
> $this->db->transaction_begin();
>
> foreach ($array as $dataset)
> {
>       $this->db->query("INSERT INTO...
> }
>
> if(!some condition)
> {
>       $this->db->transaction_abort();
>       $receipt['error'][] = array('msg'=> lang('an error message'));
> }
> else
> {
>       $this->db->transaction_commit();
>       $receipt['message'][] = array('msg'=> lang('success'));
> }
>   
yeah... good idea

> *4)
> translations for menu items (within applications) in common?
> (all menus for all apps are parsed at login)
>   
Yeas, API documentation needs to be completed with many things

> *5)
> 10.1 Standard requirements
> - at least php 5.2
>   
ok

( i think i can add the standard coding rules in the last chapter)
> *6
> 11.2 Hooking into Administration page - handled by the new menu
> 11.3 Hooking into Preferences page - handled by the new menu
>   
that will be removed then
> *7)
> Some words on ACL2, custom fields and custom functions?
>   
yes ACL2 needs probably a full chapter... near database and templates in
think

> Regards
>
> Sigurd
>   
Thank you Sigurd

Maât