[Phpgroupware-tracker] [Bug #1640] Problems with setup on Windows NT 4.0, MS SQL Server 7.0

[nobody]

=================== BUG #1640: FULL BUG SNAPSHOT ===================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=1640&group_id=509

Submitted by: anokiy                    Project: phpGroupWare                   
Submitted on: 2002-Nov-07 15:45
Category:  API - Setup                  Bug Group:  0.9.14 release              
Severity:  5 - Major                    Priority:  None                         
Resolution:  None                       Assigned to:  None                      
Status:  Open                           Component Version:  ZIP                 
Platform Version:  Windows              Reproducibility:  Every Time            

Summary:  Problems with setup on Windows NT 4.0, MS SQL Server 7.0

Original Submission:  I found the following two problems:

Errors appeared when setup tried to create the tables in the server. The tables 
would be created, but when setup tried to insert any values in the tables, 
validation would fail due to unexpected null values. 

The reason is that the database routines assume default ANSI behavior for table 
creation, and specifically that fields are nullable unless specified otherwise. 
This is not true for MS SQL 7.0, as the default for new fields is NOT nullable. 

This can be changed at the database level by entering the database properties 
dialog, Options tab, and checking the ‘ANSI NULL default’ property. I would 
recommend that this is explained in the installation docs, or that the 
installation routines are changed to eliminate this assumption.

The second error is that, even when the tables were created, the setup routines 
didn’t detect them. This meant that when the tables finished installing, 
instead of moving onto the next step, you were redirected to the previous one. 
Trying to create the tables again gave errors, of course.

The reason for this is in the table_names() function from the 
phpgwapi\inc\class.db_mssql.inc.php file:

function table_names()
{
        $this->query("select name from sysobjects where type='u' and name != 
'dtproperties'");
        $i = 0;
        while ($info = @mssql_fetch_row($this->Query_ID))
        {
                $return[$i]['table_name'] = $info[0];
                $return[$i]['tablespace_name'] = $this->Database;
                $return[$i]['database'] = $this->Database;
                $i++;
        }
        return $return;
}

For MS SQL Server 7.0, table objects are not type ‘u’, they are type ‘U’, so it 
should read like this:

$this->query("select name from sysobjects where type='U' and name != 
'dtproperties'");

I will report back if I find any other errors.



No Followups Have Been Posted


CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=1640&group_id=509