[Phpgroupware-tracker] [Patch #434] ACL Groups enhancements

[nobody]

Patch #434 has been updated. 

Project: 
Category: API -  phpGWapi
Status: Open
Summary: ACL Groups enhancements

Follow-Ups:

Date: 2002-Aug-10 01:11
By: kellin

Comment:
Corrected patch - found errors in editing user accounts.

Contains patch for following:

Email pagination correction - always paginate on correct multiple, if all 
messages deleted, move to previous screen that has content.

ACL - added ACL groups as well as membership groups. ACL groups do not have 
visible members but can be used to assign permissions to applications w/o 
exposing membership to general users.

Corrected 8/9/02.
-------------------------------------------------------

Date: 2002-Aug-10 14:11
By: kellin

Comment:
Corrected a few erroneous lookups, added a few functions to clean up membership 
list lookups etc in the class.acl_shared.inc.php and used them in the 
class.uiaclprefs.inc.php. Allows same functionality to be used elsewhere as 
needed.
-------------------------------------------------------

Date: 2002-Aug-10 14:13
By: kellin

Comment:
Corrected a few erroneous lookups, added a few functions to clean up membership 
list lookups etc in the class.acl_shared.inc.php and used them in the 
class.uiaclprefs.inc.php. Allows same functionality to be used elsewhere as 
needed.
-------------------------------------------------------

Date: 2002-Aug-12 02:47
By: kellin

Comment:
Corrected email pagination instability in non INBOX folders.
-------------------------------------------------------

Date: 2002-Sep-01 09:39
By: Zone

Comment:
Assigning to Seek3r, ACL is his territory.

BUT, could you (the submitter) please re-submit the patches in a easier to use 
format?  The email patch should be split up from the ACL patch (and addressbook 
and weather unless there is a good reason).  Also, the .diff files appear to be 
complete files, but in diff format without specifying the file to patch in the 
.diff itself.  So it makes it very hard to apply the changes.

Take a look at this page for information on the preferred patch format:
http://docs.phpgroupware.org/patches.php

Thanks,
Jason
-------------------------------------------------------

Date: 2002-Dec-07 14:53
By: skwashd

Comment:
The email issues should already be fixed.  I have allocated this to kneche (our 
ldap dev) to look at.  There are additional comments on this one at 
https://savannah.gnu.org/support/?func=detailsupport&support_id=100483&group_id=509

Cheers
-------------------------------------------------------

Date: 2002-Dec-09 17:16
By: kellin

Comment:
Hate to break it to you but the email issue has NOT been fixed. Heck, it hasn't 
been touched because no one seems to understand that I'm not writing 
gobbldeygook, and believes that I must be on crack or something. So I've 
separeted out the patch as requested, compared against the latest CVS tree, and 
posted the patch. It's numbrer 785.

Now, the thing to keep in mind about that particular patch is this. It makes 
the email application operate consistently instead of running willy-nilly like 
it has been.

That being said, I have updated the ACL patch in this patch.

So the email thing is no longer bundled (as requested).

This patch adds opaque groups as suggested by me prior.

It is also in the 'correct' format.

I HAVE had to add a few language translations. I had to add them manually to 
the database to get everything to show correctly.

Thanks!!! :)

insert into lang
values('group type','common','en','Type of Group');
insert into lang
values('acl group','common','en','ACL Group');
insert into lang
values('membership group','common','en','Membership Group');

Cheers!!! :)

Shamim
BA BS
-------------------------------------------------------

Date: 2002-Dec-09 18:03
By: skwashd

Comment:
Hey Shamim,

Thanks for this.  As i said in my last post it has been allocated to our ldap 
developer.  As this is a new feature it can only be added to our head (dev 
branch) code.  As part of the next release we are planning to completely 
overhaul the accounts/acl system.  This is not my area, but i could use the 
opaque groups for at least one of my clients.

As for the email patch, there has been a lot of work on the email app before 
the 0.9.14.001 release.  I lost track of what had and had not been fixed.  
Sorry about the confusion.  That patch has also been allocated.

We have patch guidelines to make it as easy as possible for the person applying 
the patch to do so, as it is already a time consuming process to read through 
the code, apply and test for both branches.

Thanks for the contribution.

Cheers
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://savannah.gnu.org/patch/?func=detailpatch&patch_id=434&group_id=509