phpgroupware-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Phpgroupware-tracker] [bugs #3373>] Bad relations between phpgw_log and


From: Dave Hall
Subject: [Phpgroupware-tracker] [bugs #3373>] Bad relations between phpgw_log and phpgw_accounts
Date: Wed, 21 Apr 2004 04:09:45 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040405 Firefox/0.8

This mail is an automated notification from the bugs tracker
 of the project: phpGroupWare.

/**************************************************************************/
[bugs #3373>] Latest Modifications:

Changes by: 
                Dave Hall <address@hidden>
'Date: 
                Wed 04/21/04 at 08:09 (Australia/Melbourne)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Invalid
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
The code mentioned in the report is no longer in the 16 branch.  It should be 
fixed up in the merge2HEAD.






/**************************************************************************/
[bugs #3373>] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=3373>>
Project: phpGroupWare
Submitted by: Kai Hofmann
On: Tue 04/29/03 at 09:04

Category:  API - Admin
Item Group:  devel cvs
Severity:  5 - Average
Priority:  5 - Normal
Resolution:  Invalid
Assigned to:  skwashd
Status:  Closed
Component Version:  CVS
Platform Version:  None
Reproducibility:  Every Time


Summary:  Bad relations between phpgw_log and phpgw_accounts

Original Submission:  Within the admin module there are two different relations 
between phpgw_log and phpgw_accounts.
An if statement decides between the two variants.
This is absolutly evil! - only one column should be used for relations between 
tables!

                                $parms['where'] = array('phpgw_log.log_user = 
phpgw_accounts.account_id');
                                $parms['where'][] = 'phpgw_log.log_id = 
phpgw_accounts.account_id';
./admin/inc/class.solog.inc.php


Follow-up Comments
------------------


-------------------------------------------------------
Date: Wed 04/21/04 at 08:09         By: skwashd
The code mentioned in the report is no longer in the 16 branch.  It should be 
fixed up in the merge2HEAD.

-------------------------------------------------------
Date: Wed 04/21/04 at 07:41         By: cboettger
Kai, make a suggestion how to improve it ...












For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=3373>>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/







reply via email to

[Prev in Thread] Current Thread [Next in Thread]