[Phpgroupware-tracker] [bugs #10279] calendar can't handle Dates before 1970

[Dave Hall]

This mail is an automated notification from the bugs tracker
 of the project: phpGroupWare.

/**************************************************************************/
[bugs #10279] Latest Modifications:

Changes by: 
                Dave Hall <address@hidden>
'Date: 
                Thu 09/09/2004 at 21:21 (Australia/Melbourne)

------------------ Additional Follow-up Comments ----------------------------
It isn't as straight forward as that.  We need to support php on multiple 
platforms, and windoze does not support pre1970 date timestamps.  See: 
http://www.php.net/date

"Note:  The valid range of a timestamp is typically from Fri, 13 Dec 1901 
20:45:54 GMT to Tue, 19 Jan 2038 03:14:07 GMT. (These are the dates that 
correspond to the minimum and maximum values for a 32-bit signed integer). On 
Windows this range is limited from 01-01-1970 to 19-01-2038."

You could look at http://phplens.com/phpeverywhere/adodb_date_library, but it 
would also require schema changed and a major find and replace within the code.

You are free to do what you want with pbgw but how phpgw deals with the 
problem, is something I will think about.






/**************************************************************************/
[bugs #10279] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=10279>
Project: phpGroupWare
Submitted by: Matthias Leonhardt
On: Mon 09/06/2004 at 12:16

Category:  calendar
Item Group:  0.9.16.003
Severity:  5 - Average
Priority:  5 - Normal
Resolution:  None
Privacy:  Public
Assigned to:  skwashd
Status:  Open
Component Version:  CVS
Platform Version:  GNU/Linux - SuSE
Reproducibility:  None
Planned Release:  0.9.18.000
Fixed Release:  


Summary:  calendar can't handle Dates before 1970

Original Submission:  while syncing we use
$this->bo_iCal->import($data_lines, true, $timestamp);
to get new calendar-entries.
But if we have an entry (i.e. birthday) before 1970 the calendar can't handle 
this. php produces warnings: localtime doesn' support negative values.
perhapps you know a way to handle this.
kind regards,
Matthias

Follow-up Comments
------------------


-------------------------------------------------------
Date: Thu 09/09/2004 at 21:21       By: Dave Hall <skwashd>
It isn't as straight forward as that.  We need to support php on multiple 
platforms, and windoze does not support pre1970 date timestamps.  See: 
http://www.php.net/date

"Note:  The valid range of a timestamp is typically from Fri, 13 Dec 1901 
20:45:54 GMT to Tue, 19 Jan 2038 03:14:07 GMT. (These are the dates that 
correspond to the minimum and maximum values for a 32-bit signed integer). On 
Windows this range is limited from 01-01-1970 to 19-01-2038."

You could look at http://phplens.com/phpeverywhere/adodb_date_library, but it 
would also require schema changed and a major find and replace within the code.

You are free to do what you want with pbgw but how phpgw deals with the 
problem, is something I will think about.

-------------------------------------------------------
Date: Thu 09/09/2004 at 09:08       By: Matthias Leonhardt <mleonhardt>
So we have to make a patch for our pbgroupware-branch.
Are all of these changes really neccessary? Perhapps it helps if I write a 
php-function which is able to use negative timestamps so we get the mktime 
function working with it.

Cheers,
Matthias


-------------------------------------------------------
Date: Thu 09/09/2004 at 09:06       By: Matthias Leonhardt <mleonhardt>
Did the suggestion below solve the problem?

-------------------------------------------------------
Date: Thu 09/09/2004 at 08:10       By: Dave Hall <skwashd>
Before you go and get all irrationaly about this problem again, as you did in 
bug #10331, stop and relax for a minute.

Here is the project policy:
* No schema changes in stable
* No new features in stable
* Bug fixes in 16 only

Sync is not a supported 16 module, so any problems it has working with 16 is 
not a bug in the 16 branch.

A fix for this would involve major changes for the calendar app:

* db schema change to support doubles instead of ints for dates

* change all of the logic to use julian dates

* logic to support storing the time component of the event as a decimal (1 
second = 0.000000193 julian days)

* conversion scripts to transfer all of the data to the new schema.

* some testing would also be useful

This will not be fixed quickly.  I have little interest atm spending the huge 
amounts of time required to fix this.  The calendar app needs some serious 
attention, fixing this can wait until I have time to fix most of the problems 
at once.

-------------------------------------------------------
Date: Tue 09/07/2004 at 21:33       By: Dave Hall <skwashd>
won't be fixed in 16.  Also birthdays are recurring events, which should not 
have been entered pre1970.

This is more of a problem in the addressbook, which is covered by a seperate 
bug report.




CC List
-------

CC Address                          | Comment
------------------------------------+-----------------------------
cboettger                           | calendar-bug im savannah...









For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=10279>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/