[Phpgroupware-tracker] [patch #6572] A test on using PDO in db-class

[Dave Hall]

Update of patch #6572 (project phpgroupware):

                  Status:                    None => Postponed              

    _______________________________________________________

Follow-up Comment #5:

This code isn't in a state that can be used, for the following reasons:

 * trunk is currently being stabilised for a release

 * It drops important functionality like __clone() and __destruct()

 * The "test" code bears no relationship to real world phpgw operations so
the stated performance claims can't be verified.

 * There are bigger issues with the db abstraction layer than using PDO or
not.  These issues should be addressed in a thorough review of the db code

 * The code is tainted as it has been copied and pasted from an "All Rights
Reserved" licensed site - as acknowledged in the initial comment

 * $line and $file aren't needed when calling query as the error handler gets
this information anyway

 * It is pretty easy to switch to PDO while still using ADOdb.

 * The code needs to be updated for PHP5

 * The list of other changes looks rather light on and incomplete.

 * There are other issues, but I think this list alone justifies postponing
it until after the next release.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6572>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/