Re: cleanup patch / design rules

[Ingo Ruhnke]

David Philippi <address@hidden> writes:

> If I guess right, those are only for caching purposes?

Most (or at least some) are parent-pointers. GUI elements have a
pointer to the GUIManager and such.

When the pointers are just there for caching purpose, they should
probally be removed and replaced with an inline getter method. If
calling the getter-method looks to ugly, like:

get_world()->get_pingu()->find_pingu(x, y)

one should add the caching varibable to the member function that uses
it and not to the class.

> How about using a reference instead? Change
> 
> foo* bar = get_pointer() into foo& bar = *get_pointer()

That might work in a few cases, but in general references are to
inflexible (no null element, no way to reset them, etc.), so I avoid
them mostly in classes.

We should probally add some wrappers around new/delete to make it
easier to track them and to add some bookkeeping to catch double
deletes, etc.

-- 
WWW:      http://pingus.seul.org/~grumbel/ 
Games:    http://pingus.seul.org/~grumbel/gamedesigns/
JabberID: address@hidden 
ICQ:      59461927