[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Rewrite ios_read_int

From: Jose E. Marchesi
Subject: Re: [PATCH] Rewrite ios_read_int
Date: Sun, 03 Nov 2019 21:59:39 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi Egeyar.
    The following patch rewrites ios_read_int to also include unaligned values
    and non-trivial int sizes. While doing so, moves the common functionality
    between ios_read_int and ios_read_uint into ios_read_int_common.

I just applied it.  The abstraction in ios_read_int_common is nice.
    The functionality is externally tested. If you don't mind, I'll add the
    test cases into poke, after implementing ios_write_int/uint as well.

While I understand the need for unit testing the IOS subsytem, it is
also good to add system tests to poke.map mapping signed integers in a
similar way there are tests mapping unsigned integers.

I'm talking about tests like the following, inspired in maps-uint-7.pk:


/* { dg-command { .set obase 10 } } */
/* { dg-command { int<22> @ 0#b } } */
/* { dg-output "-194523" } */

You plan to add these at some point?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]