[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] Add iterators to loop over pkl_env

From: Jose E. Marchesi
Subject: Re: [PATCH 2/4] Add iterators to loop over pkl_env
Date: Thu, 14 Nov 2019 14:06:19 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi John.

    +struct pkl_ast_node_iter
    +  int bin;           /* The bin in which this node resides.  */
    +  pkl_ast_node node; /* A pointer to the node itself.  */
    +void pkl_env_iter_begin (pkl_env env, struct pkl_ast_node_iter *iter);
    +void pkl_env_iter_next (pkl_env env, struct pkl_ast_node_iter *iter);
    +bool pkl_env_iter_end (pkl_env env, const struct pkl_ast_node_iter *iter);

I would prefer to refer to entries in the hash table as "buckets" and
not "bins", if you don't mind.  That's what the current codebase does.

Other than that, The iterators interface seems OK for master.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]