|
From: | Jose E. Marchesi |
Subject: | Re: [PATCH] Allow .load only on suitable file system entries |
Date: | Tue, 26 Nov 2019 11:58:26 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hi John. I see that gnulib provides a module `fstat' for systems not providing ones. Then it uses it in lib/read-file.c like this: if (fstat (fileno (stream), &st) >= 0 && S_ISREG (st.st_mode)) { ... } I would suggest to use the same idiom (and import the fstat module) in pk_file_readable. WDYT?
[Prev in Thread] | Current Thread | [Next in Thread] |