[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] New function posix_time32 to map timestamps

From: Jose E. Marchesi
Subject: Re: [PATCH] New function posix_time32 to map timestamps
Date: Thu, 12 Dec 2019 12:28:35 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi John.

Very nice!  :)

But it seems to me that it would be better to split this in two parts:

- A standard library function that gets an uint<32> and returns a string
  with the formatted date.  Something like asctime.

- A pickle pickles/posix.pk defining the POSIX_Time32 struct, whose
  pretty-printer uses asctime.

    +/*** Date and Time.  */
    +deftype posix_time32 = struct

We follow a convention to use Camel_Case for type names in poke.

    +  uint<32>  seconds;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]