[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use standard macro for bug report address

From: Jose E. Marchesi
Subject: Re: [PATCH] Use standard macro for bug report address
Date: Wed, 15 Jan 2020 13:31:48 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

             -Subproject commit 611869be9f1083e53305446d90a2909fc89914ef
             +Subproject commit 9e5f20f4cf5ad2d4ae254761cfa4e47ff0ed4698
         Watchout on this thunk.  Seems to be something wrong with your gnulib.
    Thanks for pointing that out.
    I really hate git submodules for exactly this reason.   They are a
    faulty idea and should be deprecated.  Nobody should use them.
John you still committed the thunk above.
Please fix the gnulib commit.

$ git show
commit 7d85e065f5d34b782b30ab1142cb6ffd380b9583
Author: John Darrington <address@hidden>
Date:   Wed Jan 15 09:13:40 2020 +0100

    Use standard macro for bug report address

diff --git a/ChangeLog b/ChangeLog
index a418c5f..4c19ada 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2020-01-18 John Darrington <address@hidden>
+       * src/pkl.c: Use std macro for bug report address.
 2020-01-14  Jose E. Marchesi  <address@hidden>
        * src/pkl-anal.c (pkl_anal2_ps_offset): Remove unused local
diff --git a/gnulib b/gnulib
index 611869b..9e5f20f 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 611869be9f1083e53305446d90a2909fc89914ef
+Subproject commit 9e5f20f4cf5ad2d4ae254761cfa4e47ff0ed4698
diff --git a/src/pkl.c b/src/pkl.c
index 1f58728..a522b90 100644
--- a/src/pkl.c
+++ b/src/pkl.c
@@ -742,8 +742,8 @@ pkl_ice (pkl_ast ast,
       pk_printf ("Important information has been dumped in %s.\n",
       pk_puts ("Please attach it to a bug report and send it to");
-      pk_term_hyperlink ("mailto:address@hidden";, NULL);
-      pk_puts (" address@hidden");
+      pk_term_hyperlink ("mailto:"; PACKAGE_BUGREPORT, NULL);
+      pk_puts (" " PACKAGE_BUGREPORT);
   pk_term_end_hyperlink ();
   pk_puts (".\n");

reply via email to

[Prev in Thread] Current Thread [Next in Thread]