poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] testsuite: exit with 77 if `runtest' is not installed


From: Dan Čermák
Subject: Re: [PATCH] testsuite: exit with 77 if `runtest' is not installed
Date: Wed, 29 Jan 2020 00:13:00 +0100

FTR: this has been obsoleted by commit
15e90bafc4278ccbf6b8162b8b558417bf065607 to the master branch.

address@hidden (Jose E. Marchesi) writes:

> Hi Dan.
>
>     From: Dan Čermák <address@hidden>
>     
>     ---
>      ChangeLog             | 4 ++++
>      testsuite/Makefile.am | 2 +-
>      2 files changed, 5 insertions(+), 1 deletion(-)
>     
>     diff --git a/ChangeLog b/ChangeLog
>     index 1ddcbab2..a6cd1dbb 100644
>     --- a/ChangeLog
>     +++ b/ChangeLog
>     @@ -1,3 +1,7 @@
>     +2020-01-23  Dan Čermák  <address@hidden>
>     +
>     + * testsuite/Makefile.am: Exit with 77 if `runtest' is not missing
>     +
>      2020-01-17  Jose E. Marchesi  <address@hidden>
>      
>       * src/pkl-tab.y (function_type_specifier): Fix definition to not
>     diff --git a/testsuite/Makefile.am b/testsuite/Makefile.am
>     index 77e0c249..e0cbac9d 100644
>     --- a/testsuite/Makefile.am
>     +++ b/testsuite/Makefile.am
>     @@ -30,5 +30,5 @@ check-DEJAGNU: site.exp
>                POKEDATADIR="$(top_srcdir)/src" \
>               $$runtest --tool $(DEJATOOL) --srcdir $${srcdir} --objdir 
> $(builddir) \
>                       $(RUNTESTFLAGS); \
>     - else echo "WARNING: could not find \`runtest'" 1>&2; :;\
>     + else echo "WARNING: could not find \`runtest'" 1>&2; exit 77;\
>       fi
>
> Since now the `make' process is returning an error status, I would
> s/WARNING/ERROR/ above.
>
> Other than that, OK for master.
> Thanks!

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]