[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: Fix build with gettext 0.20.1

From: Eric Blake
Subject: Re: [PATCH] build: Fix build with gettext 0.20.1
Date: Mon, 24 Feb 2020 16:39:09 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/24/20 4:35 PM, Eric Blake wrote:
While the gnulib libtextstyle replacement compiled fine, Fedora 31's
libtextstyle-devel from gettext 0.20.1 lacks the hyperlink support
added upstream in gettext 0.21, causing:

pk-term.c: In function 'pk_term_init':
pk-term.c:75:21: error: lvalue required as left operand of assignment
     75 |     style_file_name = NULL;

* src/pk-term.c (pk_term_init): Use correct conditional.
  ChangeLog     | 4 ++++
  src/pk-term.c | 2 +-
  2 files changed, 5 insertions(+), 1 deletion(-)

This patch alone is not enough to fix testsuite failures:

Running /home/eblake/poke/testsuite/poke.pkl/pkl.exp ...
FAIL: poke.pkl/printf-class-1.pk output pattern test
FAIL: poke.pkl/printf-class-2.pk output pattern test
FAIL: poke.pkl/printf-class-3.pk output pattern test
FAIL: poke.pkl/printf-class-4.pk output pattern test
Running /home/eblake/poke/testsuite/poke.std/std.exp ...

                === poke Summary ===

# of expected passes            2893
# of unexpected failures        4

Those tests have
/* { dg-require libtextstyle } */
which is not sufficient to detect if poke was built with hyperlink support.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]