poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: Fix build with gettext 0.20.1


From: Eric Blake
Subject: Re: [PATCH] build: Fix build with gettext 0.20.1
Date: Tue, 25 Feb 2020 22:06:16 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 2/25/20 9:58 AM, Dan Čermák wrote:
Hi Eric,

Eric Blake <address@hidden> writes:

While the gnulib libtextstyle replacement compiled fine, Fedora 31's
libtextstyle-devel from gettext 0.20.1 lacks the hyperlink support
added upstream in gettext 0.21, causing:

pk-term.c: In function 'pk_term_init':
pk-term.c:75:21: error: lvalue required as left operand of assignment
     75 |     style_file_name = NULL;

Hm, that is certainly weird, because I cannot reproduce these issues on
OBS for neither Fedora target:
https://build.opensuse.org/package/show/home:dancermak:poke/poke

Is there something that I am missing here?

I found the problem.

I initially built without libtextstyle-devel, which caused gnulib to generate lib/textstyle.h. Then I installed libtextstyle-devel, and rebuilt in the same directory without cleaning up first. Configure was able to detect the library, but gnulib does NOT remove a .h file that it no longer generates (this is possibly a bug worth fixing in gnulib, but not poke's fault). A clean build does not suffer from the problem, and my incremental build was fixed when I did 'rm lib/textstyle.h'.

Therefore, I withdraw this patch as unnecessary.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]