[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/7] More efficient I/O

From: Jose E. Marchesi
Subject: Re: [PATCH 0/7] More efficient I/O
Date: Sat, 29 Feb 2020 13:53:49 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hi Eric.

    I first noticed this while working on my NBD driver.  While this
    doesn't completely batch up large I/O, it sure makes 64-bit access
    more efficient.
    Eric Blake (7):
      ios: Drop Position column from .info ios
      ios: Pass offset to low-level macros.
      ios: Prove we don't need seek.
      ios: Drop unused seek/tell callbacks.
      ios: Change from getchar to pread device interface.
      ios: Utilize buffer reads.
      ios: Utilize buffer writes.

I went thru the patch series and, in my opinion, it is good for master.
The pread/pwrite like interface is definitely better than the getc/putc.

However, I would like to hear Egeyar's opinion about it, as she wrote
the integer read/write code in ios.c, and therefore is in a better
position than me to do a review in that area.

The patch 'ios: Drop Position column from .info ios' can go in right


reply via email to

[Prev in Thread] Current Thread [Next in Thread]