[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ios: Avoid data leak and write-beyond-bounds in mem.

From: Eric Blake
Subject: Re: [PATCH] ios: Avoid data leak and write-beyond-bounds in mem.
Date: Mon, 2 Mar 2020 07:49:31 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/2/20 7:41 AM, Jose E. Marchesi wrote:

Hi Eric.
* testsuite/poke.cmd/mem-1.pk: New test.
     * testsuite/poke.cmd/mem-2.pk: Likewise.
     * testsuite/poke.cmd/mem-3.pk: Likewise.

I would limit the tests in poke.cmd to make sure that the command itself
(in this case the dot-command) works and processes the arguments
properly, etc.

Testing that the memory is zeroed, that trying to grow more than 4098
bytes results in an exception, etc, fits better in poke.pkl/ios-mem-*.pk
tests, using `open' rather than `.mem'.

Okay, we already have poke.cmd/ios-1.pk that tests .mem; so I'm fine renaming all 3 of these to poke.pkl/ios-mem*.pk.

Other than that, this is OK for master.
Thanks! :)

Pushing shortly with that change.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]