[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] run.in: Default to running the poke binary

From: John Darrington
Subject: Re: [PATCH] run.in: Default to running the poke binary
Date: Sun, 22 Mar 2020 11:26:15 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

On Sun, Mar 22, 2020 at 11:08:06AM +0100, Jose E. Marchesi wrote:
     Hi John.
          # Now run the program
         -exec "$@"
         +if test $# -eq 0; then
         +    exec poke
         +    exec "$@"
     I don't like this change.  That script has clear semantics as it is now:
     set the environment and run the given command-line.  Specializing it
     this way may be confusing.

I see your point of view.  However it's not particularly useful to have "./run" 
doing - absolutely nothing.
Would this patch be clearer?

diff --git a/run.in b/run.in
index 7c0c031d..a97621bd 100644
--- a/run.in
+++ b/run.in
@@ -43,4 +43,4 @@ MALLOC_PERTURB_=$random_val
 # Now run the program
-exec "$@"
+exec "${@:-poke}"

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]