Re: [PATCH] Remove unused code

[Jose E. Marchesi]

Hi John.

That code will be used at some point, when we implement support for
enums.  I think it doesn't harm to have support for these AST node
types.

    ---
     ChangeLog     |  5 +++++
     src/pkl-ast.c | 17 -----------------
     src/pkl-ast.h |  4 ----
     3 files changed, 5 insertions(+), 21 deletions(-)
    
    diff --git a/ChangeLog b/ChangeLog
    index d1a5ea5d..e0bb8d36 100644
    --- a/ChangeLog
    +++ b/ChangeLog
    @@ -1,3 +1,8 @@
    +2020-03-29  John Darrington <address@hidden>
    +
    +   * src/pkl-ast.c: (pkl_ast_make_identifier): Delete.
    +   * src/pkl-ast.h: (pkl_ast_make_identifier): Delete.
    +
     2020-03-29  John Darrington <address@hidden>
     
        *doc/poke.texi: Miscellaneous minor fixes.
    diff --git a/src/pkl-ast.c b/src/pkl-ast.c
    index 50cff688..61ef8981 100644
    --- a/src/pkl-ast.c
    +++ b/src/pkl-ast.c
    @@ -114,23 +114,6 @@ pkl_ast_make_identifier (pkl_ast ast,
       return id;
     }
     
    -/* Build and return an AST node for an enumerator.  */
    -
    -pkl_ast_node
    -pkl_ast_make_enumerator (pkl_ast ast,
    -                         pkl_ast_node identifier,
    -                         pkl_ast_node value)
    -{
    -  pkl_ast_node enumerator
    -    = pkl_ast_make_node (ast, PKL_AST_ENUMERATOR);
    -
    -  assert (identifier != NULL);
    -
    -  PKL_AST_ENUMERATOR_IDENTIFIER (enumerator) = ASTREF (identifier);
    -  PKL_AST_ENUMERATOR_VALUE (enumerator) = ASTREF (value);
    -
    -  return enumerator;
    -}
     
     /* Build and return an AST node for a conditional expression.  */
     
    diff --git a/src/pkl-ast.h b/src/pkl-ast.h
    index 95a28a0a..41d0aa38 100644
    --- a/src/pkl-ast.h
    +++ b/src/pkl-ast.h
    @@ -521,10 +521,6 @@ struct pkl_ast_enumerator
       union pkl_ast_node *value;
     };
     
    -pkl_ast_node pkl_ast_make_enumerator (pkl_ast ast,
    -                                      pkl_ast_node identifier,
    -                                      pkl_ast_node value);
    -
     /* PKL_AST_ENUM nodes represent enumerations, having semantics much
        like the C enums.