[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Accept %DATADIR% anywhere in data load path
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH] Accept %DATADIR% anywhere in data load path |
|
Date: |
Thu, 09 Apr 2020 11:28:06 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Tim.
+/* Replace all occurrences of 'search' in 'in' by 'replace'.
+ * Return 'in' in case 'search' was not found, else
+ * return a new allocated string with the replaced sequences.
+ * Return NULL on allocation failure.
+ */
Please follow the convention of using caps when referring to function
arguments. For example:
Replace all occurrences of SEARCH in IN by REPLACE.
Other than that, this is OK for master.
Thanks! :)