Re: malloc vs xmalloc in pk_str_replace

[Jose E. Marchesi]

Hi Bruno.
    
    In a current build, I get the warnings:
    
    pk-utils.c:184:13: warning: implicit declaration of function 'malloc' 
[-Wimplicit-function-declaration]
    pk-utils.c:184:13: warning: incompatible implicit declaration of built-in 
function 'malloc'
    
    This is caused by use of malloc() without '#include <stdlib.h> in this file.
    
    But why use malloc() at all, when
      - other functions in the same file use xmalloc() already,
      - the caller in pkl.c does not check for a NULL result, i.e. would
        crash if the function returned NULL?

We recently moved a lot of code to a library libpoke.so, with sources in
lib/.

But that was just the first step.

Now we will be reworking every place in the library code that may abort
or exit, and that includes replacing xmallocs with mallocs and adjust
the corresponding APIs in order to report the errors to the libpoke
client.

I just pushed a patch that includes stdlib in pk-utils.c
Thanks for noticing! :)