Re: [PATCH] Return NULL instead of calling exit in pkl_new

[Tim Rühsen]

Added your description to pkl.h and pushed it.

On 10.04.20 21:09, Jose E. Marchesi wrote:
> 
> Hi Tim.
> 
>     2020-04-10  Tim Rühsen  <address@hidden>
>     
>             * lib/pkl.c (pkl_new): Return NULL instead of calling exit.
>     ---
>      ChangeLog | 4 ++++
>      lib/pkl.c | 4 ++--
>      2 files changed, 6 insertions(+), 2 deletions(-)
> 
> 
> Nice, but please add a comment documenting the function in pkl.h right
> before the prototype.  Something like this will do:
> 
> /* Create and return a new compiler.
> 
>    VM is the virtual machine that the compiler will use when it needs to
>    run Poke programs.  This happens, for example, when the compiler
>    bootstraps itself and loads libraries.
> 
>    RT_PATH should contain the name of a directory where the compiler can
>    find its run-time support files.
> 
>    If there is an error creating the compiler this function returns
>    NULL.  */
> 
> Please leave an empty line between the comment and the prototype.  I
> try to follow that style in all the header files.
> 
> Thanks!
>

signature.asc
Description: OpenPGP digital signature