[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: pickles: Fix a syntax error
From: |
Jose E. Marchesi |
Subject: |
Re: pickles: Fix a syntax error |
Date: |
Sun, 07 Jun 2020 15:48:09 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
Hi Bruno.
This is OK for master. Thanks for fixing it!
(poke) .load bpf.pk
bpf.pk:235:39: error: syntax error: unexpected ':'
printf "%<integer:%v%>", hi::lo;
^
Once this is fixed:
(poke) .load bpf.pk
bpf.pk:246:29: error: syntax error: unexpected ':'
return imm.imm64.hi::imm.imm64.lo;
^
The attached proposed patch fixes it. It's a followup to
2020-05-18
libpoke,testsuite,doc: change bit-concatenation operator from :: to :::
>From 3f83a3f47ffa963c9692e8da201838ebaf8b8657 Mon Sep 17 00:00:00 2001
From: Bruno Haible <bruno@clisp.org>
Date: Sat, 6 Jun 2020 20:47:10 +0200
Subject: [PATCH] pickles: Fix a syntax error.
* pickles/bpf.pk: Use :::, not ::.
---
pickles/bpf.pk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pickles/bpf.pk b/pickles/bpf.pk
index 36b611d..4003bca 100644
--- a/pickles/bpf.pk
+++ b/pickles/bpf.pk
@@ -232,7 +232,7 @@ deftype BPF_Insn =
method _print = void:
{
print "#<";
- printf "%<integer:%v%>", hi::lo;
+ printf "%<integer:%v%>", hi:::lo;
print ">";
}
} imm64 : bpf_opcode_imm64_p (opcode);
@@ -243,7 +243,7 @@ deftype BPF_Insn =
method imm_value = int<64>:
{
if (bpf_opcode_imm64_p (opcode))
- return imm.imm64.hi::imm.imm64.lo;
+ return imm.imm64.hi:::imm.imm64.lo;
else
return imm.imm32;
}