[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] etc/pickle-mode.el: add Emacs mode for .pk files

From: Aurélien Aptel
Subject: Re: [PATCH] etc/pickle-mode.el: add Emacs mode for .pk files
Date: Mon, 08 Jun 2020 14:35:12 +0200

"Jose E. Marchesi" <jemarch@gnu.org> writes:
> My first comment is that we probably want to call this mode poke-mode
> instead of pickle-mode.  Not all Poke files are pickles.  So we would
> have:
>  poke-mode.el     -> Major mode for editing Poke programs.
>  poke-map-mode.el -> Major mode for editing Poke MAP files.
>  poke-ras-mode.el -> Major mode for editing Poke RAS files.
> and then, soon, we will add an Emacs-based editor based on poke, as the
> machine-interface evolves:
>  poke.el -> Editor for structured binary data.

Sounds good :)

> Other than that, this looks very nice.  It will be interesting to write
> an operator precedence SMIE grammar for Poke.

My sarcasm-o-meter is not working well. You mean this is going to be a
pain right? I've never used SMIE before but I suspected it wouldn't be
easy... What should I know about the operator precedence of SMIE
grammars? I only have a basic understanding of parsing in general.

Emacs ships with an Emacs-lisp bison-like parser generator (Wysent) but
I've never used it either. Sounds like a lot of work to reuse and it
won't handle invalid states as you type so I don't know.

> Where do you want to maintain the code?  I think that maintaining it in
> poke.git makes sense, as you are proposing in your patch.  Please let me

Initially I was planning to have a separate repo but later realized it
would make more sense to have it in Poke repo to keep it in sync.

I also thought that having third-party Poke things might unconsiously
(or consiously) force the Poke language to be set it stone and leave no
room for more drastic syntax changes. I would rather let you experiment
freely while it is still possible :)

> know your savannah user, and I will give you write permissions to the
> repo.  From there, I guess we can do releases in MELPA, ELPA or
> whatever.

Great, thanks. My savanah user is aaptel.

Side note: it feels really redundant to have ChangeLog entries in the
ChangeLog file AND commit message. I feel like only one should be needed.

Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg, DE
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 247165 (AG München)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]