[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add JSON Schema for Poke values.

From: Bruno Haible
Subject: Re: [PATCH] Add JSON Schema for Poke values.
Date: Wed, 08 Jul 2020 04:19:24 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-179-generic; KDE/5.18.0; x86_64; ; )

Hi Kostas,

In etc/pk-mi-json-schema.json I see indentation mistakes in lines
32 98 196..197 209 247..250 255 259 270..281.
Especially regarding arrays, it would be good to choose a certain
indentation style, and stick to it.

Also, in line 272: Why "anyOf"? Why not "oneOf"? What does a
  "PokeValue": {}


reply via email to

[Prev in Thread] Current Thread [Next in Thread]