poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pk_struct_type interface for libpoke.


From: Jose E. Marchesi
Subject: Re: [PATCH] pk_struct_type interface for libpoke.
Date: Tue, 14 Jul 2020 15:29:41 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Kostas.
    
    
    diff --git a/libpoke/libpoke.h b/libpoke/libpoke.h
    index 8fb8b48f..d2fae75b 100644
    --- a/libpoke/libpoke.h
    +++ b/libpoke/libpoke.h
    @@ -700,7 +700,8 @@ pk_val pk_offset_type_unit (pk_val type);
     
        FTYPES is a C array containing the types of each struct field. */
     
    -pk_val pk_make_struct_type (pk_val nfields, pk_val name, pk_val *fnames, 
pk_val *ftypes);
    +pk_val pk_make_struct_type 
    +(pk_val nfields, pk_val name, pk_val *fnames, pk_val *ftypes);

Please split like this:

pk_val pk_make_struct_type (pk_val nfields, pk_val name, pk_val *fnames,
                            pk_val *ftypes);

Other than that, the patch is OK for master.
Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]