[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix build failure during "make distcheck"

From: Jose E. Marchesi
Subject: Re: fix build failure during "make distcheck"
Date: Fri, 17 Jul 2020 19:32:55 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Bruno.

    There are three possible fixes to this situations:
    (a) List only individual files in EXTRA_DIST. Enumerate them! Then you don't
        need to worry about garbage files (editor backups, core dumps, whatever)
        getting accidentally packaged in the tarball.
    (b) Use a dist-hook to remove unnecessary files from a distribution. See
    (c) List only individual files in EXTRA_DIST, for directories that may 
        built files. For directories that contain only data files, list the
        directory, but use 'git status' to make sure the directory contains no
        extra / garbage files.
    Here are two patches, that implement (a) or (c), respectively. Either fixes
    "make distcheck". My preference is (a), since it's
      - the safest and
      - consistent with uses of EXTRA_DIST in other GNU packages.

I agree that (a) is the best way to go.
OK for master.

It would be good to have a reminder in HACKING to add new tests to


reply via email to

[Prev in Thread] Current Thread [Next in Thread]