[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] libpoke: free the buffer of stream device only in read mo
|
From: |
Mohammad-Reza Nabipoor |
|
Subject: |
Re: [PATCH v2] libpoke: free the buffer of stream device only in read mode |
|
Date: |
Sun, 18 Oct 2020 20:58:07 +0330 |
On Sun, Oct 18, 2020 at 06:50:55PM +0200, Jose E. Marchesi wrote:
> > ```c
> > if (buffer == NULL)
> > return 1;
> > ```
> >
> > Is this OK?
>
> Yes, but since ios_buffer_free can't fail, please also change it to
> return `void' instead of `int'.
>
OK.
> >> On the other hand, do you have a savannah account?
> >
> > Yes. mnabipoor.
>
> Ok, now you should have write access to the repo.
> Welcome on board :)
Wow! Thanks! It's a great pleasure :)
Regards,
Mohammad-Reza