Re: [PATCH v3] libpoke, poke, testsuite: Make error handling of public API consistent

[Mohammad-Reza Nabipoor]

Hi, Jose.

On Wed, Nov 11, 2020 at 11:27:32PM +0330, Mohammad-Reza Nabipoor via poke-devel 
wrote:
>  
>  const char *
>  pk_ios_handler (pk_ios io)
>  {
> +  pkc->status = PK_OK;
>    return ios_handler ((ios) io);
>  }
>  
>  uint64_t
>  pk_ios_flags (pk_ios io)
>  {
> +  pkc->status = PK_OK;
>    return ios_flags ((ios) io);
>  }
>  

I made a stupid last-minute mistake in `pk_ios_hanlder` and `pk_ios_flags`
functions. I think my stupid mistake is obivious.

But I want to suggest to add `pk_compiler` argument to these functions to make
them consistent with others `pk_ios_*` functions.
And also to the following functions:
  - `pk_ios_get_id`
  - `pk_ios_get_dev_if_name`
  - `pk_ios_size`

Currently the `pkc` is unused; but it'll be used in future when `libpoke` wants
to get rid of global internal states (which I think is a good thing).


Regards,
Mohammad-Reza