poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] libpoke,testsuite: Fix strings to handle backslash and newli


From: Mohammad-Reza Nabipoor
Subject: Re: [PATCH] libpoke,testsuite: Fix strings to handle backslash and newline chars
Date: Fri, 20 Nov 2020 20:56:05 +0330

Hi, Jose.

On Fri, Nov 20, 2020 at 06:18:54PM +0100, Jose E. Marchesi wrote:
> 
> Hi Mohammad.
> 
> > 2020-11-20  Mohammad-Reza Nabipoor  <m.nabipoor@yahoo.com>
> >
> >     * libpoke/pkl-lex.l (STRING): Fix regexp to escape backslash and
> >     newline characters correctly.
> >     * libpoke/pkl-trans.c (pkl_trans1_ps_string): Ignore `\<NEWLINE>`
> >     escape sequence.
> >     * testsuite/Makefile.am (EXTRA_DIST): Add new tests.
> >     * testsuite/poke.pkl/string-diag-2.pk: New test.
> >     * testsuite/poke.pkl/string-multiline-1.pk: Likewise.
> >     * testsuite/poke.pkl/string-multiline-diag-1.pk: Likewise.
> 
> Very nice fix, and tests too! :)

Thanks!

> This is OK for master.

Pushed.


Regards,
Mohammad-Reza


reply via email to

[Prev in Thread] Current Thread [Next in Thread]