poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] testsuite: Simplify file processing in poke.mi-json/mi-json.


From: Jose E. Marchesi
Subject: Re: [PATCH] testsuite: Simplify file processing in poke.mi-json/mi-json.c
Date: Mon, 15 Feb 2021 12:28:53 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Mohammad.

> 2021-02-15  Mohammad-Reza Nabipoor  <m.nabipoor@yahoo.com>
>
>       * testsuite/poke.mi-json/mi-json.c (test_json_to_val_to_json): Simplify
>       the JSON file selection loop.
> ---
>
> Hi, Jose.
>
> I couldn't reproduce your reported failure in testsuite/poke.mi-json/mi-json.c
> on my machine using gcc-10.2.0.
> (And I'm compiling the gcc-8.4.0 which I'll test tomorrow; it's too
> late now).

The tests failures were due to the weird inclusion of /usr/local/lib in
RPATH in the libtool wrapper script.

So they are unrelated.

>
> But I hope this patch solves the problem (and also improves the
> readability).

The patch is OK for master, provided it is tested.
Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]