[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH,V2] pickles: ctf: fix issues, support CTF slices

From: Jose E. Marchesi
Subject: Re: [PATCH,V2] pickles: ctf: fix issues, support CTF slices
Date: Wed, 17 Feb 2021 14:33:32 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> [Start Diff from V1]
> - No tabs. Hopefully its fixed this time. (also replaced some pre-existing 
> tabs
>   with spaces in CTF_Header).
> - CTF_Slice now uses offset<>
> - New type CTF_Func_Args (defined inside the CTF_Type because of a dependency
>   on info.vlen)
> [End Diff from V1]
> Use integral struct for CTF_Integer_Type and CTF_Float_Type. Fix CTF_KIND_ENUM
> to allow for a vlen number of enumerator records after the CTF type.
> CTF_KIND_FUNCTION has a trailing padding of 4 bytes if the number of function
> arguments is odd. Update the string offset in the ctf_string () function.
> Finally add support for CTF Slices.

Applied in master in your behalf, thanks! :)

I think it would be nice to have a CTF_Dictionary type in the same
spirit than BTF_Section in btf.pk.  It would contain the CTF header and
the different sections.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]