poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: build from tarball uses bison


From: Indu Bhagat
Subject: Re: build from tarball uses bison
Date: Tue, 23 Feb 2021 11:49:55 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1

On 2/20/21 5:15 AM, Bruno Haible wrote:
bison -d -t --report=state --output pk-map-tab.c \
           ../../poke/pk-map-tab.y

While the GCS allow this (see
<https://www.gnu.org/prep/standards/html_node/Utilities-in-Makefiles.html>),
it is a best practice to avoid bison as a build prerequisite, by packaging
the generated files in the tarball. See
<https://www.gnu.org/prep/standards/html_node/Makefile-Basics.html>

The attached patch to poke/Makefile.am fixes this.

The libpoke/ subdirectory has a related problem: It distributes the
pkl-tab.h and pkl-tab.c files (good!), but erases them during "make clean".
After "make clean", "make" then needs bison here as well:

bison -d -t --report=state --output pkl-tab.c \
           ./pkl-tab.y

Also fixed in the patch.

OK for master.
Thanks!

Pushed.



I am getting a build error on master branch with the usual configure and build command that worked earlier.

gcc: error: ../../poke/libpoke/pkl-tab.c: No such file or directory
gcc: fatal error: no input files

Does something in the build/configure step need to change with this commit?

Thanks
Indu



reply via email to

[Prev in Thread] Current Thread [Next in Thread]