poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Install pkgconfig file for libpoke


From: Jose E. Marchesi
Subject: Re: [PATCH] Install pkgconfig file for libpoke
Date: Fri, 26 Feb 2021 22:02:55 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> On Fr, 2021-02-26T20:45+0100, Jose E. Marchesi wrote:
>> > On Fr, 2021-02-26T19:56+0100, Jose E. Marchesi wrote:
>> >> 
>> >> Hello Thomas.
>> >> Thanks for the patch.
>> >> 
>> >> > +dnl pkg-config description
>> >> > +AX_CREATE_PKGCONFIG_INFO('libpoke/poke.pc', , , 'libpoke')
>> >> 
>> >> Where is this macro defined?
>> >
>> > It's from ax_create_pkgconfig_info.m4 from autoconf-archive.
>> > I have version 2019.01.06 of that but the m4 file carries copyright headers
>> > from 2008 so it should have been there for some time.
>> 
>> Ok... then that file should be part of the patch as well.
>
> Ok, I'll add it.

Thanks.

>> However, there is a more general concern I have regarding this.
>> 
>> Used to the GNU world I am not that familiar with the usage of .pc files
>> and pkg-config, so please bear with me but... to what extent makes sense
>> for upstream projects to provide .pc files?  I would have thought it is
>> distros that are in the situation to better provide such files, because
>> it is them that actually have control on where the stuff gets installed,
>> and therefore the right link paths and include paths and the like...
>
> It makes sense for upstream to provide this because it should be the
> same general information for all distros.  (Especially the name used
> for the .pc file itself is essentially the ID for this library for all
> consumers, so it really should not change between distros)

Establishing a canonical name for the .pc file is a good point.  One of
the problems I experience with pkg-config is that sometimes that name
changes from one distro to another.  Or, what is even worse, some
distros decide to add the version of the library (or the version of the
ABI) to the name of the file.

If providing a .pc file with poke will help to prevent distros doing
things like that, I am all for it.

> Also it's less work to do this once properly than everyone having to patch it
> in.
>
> All the link paths, locations and flags should automatically be passed from
> ./configure to the .pc file, because that actually knows how the software is
> being built.

Allright, let's add it then :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]