poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] poke: Handle the absence of current IOS in map command


From: Jose E. Marchesi
Subject: Re: [PATCH] poke: Handle the absence of current IOS in map command
Date: Sat, 27 Feb 2021 08:54:18 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Mohammad.


> +#define CUR_IOS_ID(ios_id)                                                   
>  \
> +  do                                                                         
>  \
> +    {                                                                        
>  \
> +      pk_ios cur_ios = pk_ios_cur (poke_compiler);                           
>  \
> +                                                                             
>  \
> +      if (!cur_ios)                                                          
>  \
> +        {                                                                    
>  \
> +          pk_printf (_ ("No current IOS\n"));                                
>  \
> +          return 0;                                                          
>  \
> +        }                                                                    
>  \
> +                                                                             
>  \
> +      ios_id = pk_ios_get_id (cur_ios);                                      
>  \
> +    }                                                                        
>  \
> +  while (0)
> +

I would rename the macro to SET_TO_CUR_IOS_ID.
Other than that, this is OK for both master and poke-1.

(A test would be nice yes :)).

Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]