[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: poke-1.0 and GCC < 4.6

From: Jose E. Marchesi
Subject: Re: poke-1.0 and GCC < 4.6
Date: Tue, 02 Mar 2021 08:59:19 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Bruno.

>> I am not a big fan on the cpp solution, but since I can't think on a
>> better one, lets put it in for now.
> I looked into these in more detail.
> In one case, the duplicate typedef is simply redundant.
> In two cases, the best approach I can see is a separate .h file.
> In two cases, a separate .h file is overkill, and it is simpler to just
> write 'struct foo *' in place of 'foo' in one or two places. If the typedef
> would change in the future, GCC would emit a warning.
> How about this? Tested on the said machine with GCC 4.1.x.

This is so much better :)
OK for master.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]