|
From: | Egeyar Bagcioglu |
Subject: | Re: [PATCH] Fix the behaviour of the flags in file IOD |
Date: | Mon, 15 Mar 2021 23:18:27 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
Hi José
This patch replaces the fopen in file IOD with calls to open and fdopen to make use of open's wider range of flags. Please review.This looks so much better than the existing logic! Thanks for working on this. My only comments are: - We are removing IOS_F_TRUNCATE right?
I committed that as a separate patch.
- Please use C comments, not C++ comments.
Done.
Other than that I think this is OK for both master and maint/poke-1.
Both patches are now in both master and maint/poke-1. Regards Ege
[Prev in Thread] | Current Thread | [Next in Thread] |