[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ios: avoid collision with O_RDONLY
|
From: |
David Faust |
|
Subject: |
Re: [PATCH] ios: avoid collision with O_RDONLY |
|
Date: |
Sat, 27 Mar 2021 10:44:11 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 3/26/21 5:54 PM, Jose E. Marchesi wrote:
>
> Hi David.
>
>> ios_dev_file_convert_flags was returning 0 in the case of bad flags.
>> But, many implementations define the O_RDONLY flag for `open` as 0.
>> This resulted an unhandled invalid IO flags exception when attempting
>> to open a file with the 'open' poke builtin and IOS_M_RDONLY.
>>
>> OK to install? (and probably pick to maint/poke-1?)
>
> OK for master and maint/poke-1.
> Thanks!
>
Pushed^2
Thanks.