[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] Improve portability (particularly for Woe32)

From: Georgiy Tugai
Subject: Re: [PATCH 2/5] Improve portability (particularly for Woe32)
Date: Sun, 28 Mar 2021 19:22:44 +0000

On Sunday, March 28, 2021 1:00 PM, Bruno Haible <bruno@clisp.org> wrote:

> Georgiy Tugai wrote:
> > Should I leave the HAVE_FCNTL ifdefs in, or no?
> defined HAVE_FCNTL is equivalent to !(defined _WIN32 && !defined CYGWIN).

Sure, but "HAVE_FCNTL" expresses the intent better than a WIN32 test, right? :)

e.g. if someone later figures out how to get full fcntl on Windows, or
implements a new abstraction layer comparable to Cygwin, for that matter,
that macro will still be correct.

My point is that from a Woe32 portability perspective, disabling the MI by
default would be enough, if we're planning on rewriting the MI I/O layer
anyway. I don't have enough experience with multithreaded C code to be
confident in doing that myself.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]