[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] JSON schema refactoring and adaptive code changes.

From: Jose E. Marchesi
Subject: Re: [PATCH] JSON schema refactoring and adaptive code changes.
Date: Tue, 07 Sep 2021 20:10:34 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Kostas.

> Hello Poke team!
> This is the patch which applies the whole refactoring process we’ve
> discussed about on previous threads and on IRC.
> I believe its way better than the previous schema.
> Since there are a lot of changes made, something might have slipped my
> attention. Please feel free to comment!
> Thanks.
> From 2733610c7490b43903eb3ad5a76e2417f527cd04 Mon Sep 17 00:00:00 2001
> From: kostasch <koschasialis@gmail.com>
> Date: Mon, 6 Sep 2021 17:44:08 +0300
> Subject: [PATCH] JSON schema refactoring and adaptive code changes.
> New JSON schema and implementation.
> 2021-09-06  Kostas Chasialis  <koschasialis@gmail.com>
>       * etc/pk-mi-json-schema.json (JSON Schema): Refactored the JSON schema.
>       * libpoke/libpoke.h (pk_sizeof): Function declaration.
>       * libpoke/pk-val.c (pk_sizeof): Function definition.

The libpoke.h and pk-val.c changes are OK for both master and

Regarding the JSON changes, I'm good with them provided Mohammad reviews
it and gives the ok.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]